Bugzilla – Attachment 82344 Details for
Bug 21567
WebService:ILS related tests fail during package build
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t
Bug-21567-Remove-KohaExternalContentRecordedBookst.patch (text/plain), 2.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-11-14 18:19:12 UTC
(
hide
)
Description:
Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-11-14 18:19:12 UTC
Size:
2.61 KB
patch
obsolete
>From e6c7952744eb0792da8041f40cdb16c9f7365884 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 14 Nov 2018 15:11:07 -0300 >Subject: [PATCH] Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t > >This patch removes this file. The included tests are similar to those in >the db_dependent section, with the difference that this have some things >mocked. But the tests still require name resolution and connecting to >the RB servers. This situation breaks package building without any >noticeable gain. > >The feature could be better tested by mocking WebService::ILS calls (so >no external world contact), but it belongs to a separate bug report. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/Koha_ExternalContent_RecordedBooks.t | 42 -------------------------- > 1 file changed, 42 deletions(-) > delete mode 100755 t/Koha_ExternalContent_RecordedBooks.t > >diff --git a/t/Koha_ExternalContent_RecordedBooks.t b/t/Koha_ExternalContent_RecordedBooks.t >deleted file mode 100755 >index 7fdbfaa032..0000000000 >--- a/t/Koha_ExternalContent_RecordedBooks.t >+++ /dev/null >@@ -1,42 +0,0 @@ >-#!/usr/bin/env perl >- >-use Modern::Perl; >- >-use t::lib::Mocks; >-use Test::More; >-use Test::MockModule; >- >-use Module::Load::Conditional qw( can_load ); >- >-plan tests => 3; >- >-SKIP: { >- skip "cannot find WebService::ILS::RecordedBooks::Partner", 3 >- unless can_load( modules => { 'WebService::ILS::RecordedBooks::Patron' => undef } ); >- >- use_ok('Koha::ExternalContent::RecordedBooks'); >- >- t::lib::Mocks::mock_preference('SessionStorage','tmp'); >- >- t::lib::Mocks::mock_preference('RecordedBooksLibraryID', 'DUMMY'); >- t::lib::Mocks::mock_preference('RecordedBooksClientSecret', 'DUMMY'); >- t::lib::Mocks::mock_preference('RecordedBooksDomain', 'DUMMY'); >- >- my $client = Koha::ExternalContent::RecordedBooks->new(); >- local $@; >- eval { $client->search({query => "art"}) }; >- >- ok($@ =~ /This endpoint can be called by authorized trusted app or trusted partner only/, "Invalid RecordedBooks partner credentials"); >- >- SKIP: { >- skip "no RecordedBooks partner credentials", 1 unless $ENV{RECORDEDBOOKS_TEST_LIBRARY_ID}; >- >- t::lib::Mocks::mock_preference('RecordedBooksLibraryID', $ENV{RECORDEDBOOKS_TEST_LIBRARY_ID}); >- t::lib::Mocks::mock_preference('RecordedBooksClientSecret', $ENV{RECORDEDBOOKS_TEST_CLIENT_SECRET}); >- t::lib::Mocks::mock_preference('RecordedBooksDomain', $ENV{RECORDEDBOOKS_TEST_DOMAIN}); >- >- $client = Koha::ExternalContent::RecordedBooks->new(); >- my $res = $client->search({query => "art"}); >- ok($res->{items}, "search") >- } >-} >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21567
:
80664
|
82344
|
82352
|
82393
|
82398
|
82399
|
82400