Attachment 82359 Details for Bug 21495 – Bug 21495 - Regression in hold override functionality

[patch] Bug 21495 - Regression in hold override functionality

Bug-21495---Regression-in-hold-override-functional.patch (text/plain), 2.04 KB, created by Kyle M Hall (khall) on 2018-11-15 13:39:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-11-15 13:39:32 UTC

Size: 2.04 KB

patch

obsolete

>From 1649146654ff3602ce7d27394d53c9b3d34d9fa6 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 15 Nov 2018 08:35:33 -0500
>Subject: [PATCH] Bug 21495 - Regression in hold override functionality
>
>The changes caused by the patches for bug 21495 have broken existing
>workflows for many libraries and are widely considered to be a bad move.
>We should revert this behavior.
>---
> .../prog/en/modules/admin/preferences/circulation.pref          | 2 +-
> reserve/request.pl                                              | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 43d59dbeee..6e9a987203 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -574,7 +574,7 @@ Circulation:
>               choices:
>                   yes: Allow
>                   no: "Don't allow"
>-            - staff to force addition of holds even if the patron already has the maximum number of holds allowed.
>+            - staff to override hold policies when placing holds.
>         -
>             - pref: AllowHoldsOnDamagedItems
>               choices:
>diff --git a/reserve/request.pl b/reserve/request.pl
>index db02e5286d..c3da85b10a 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -485,7 +485,7 @@ foreach my $biblionumber (@biblionumbers) {
> 
>                     push( @available_itemtypes, $item->{itype} );
>                 }
>-                elsif ( $can_item_be_reserved->{status} eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) {
>+                elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) {
>                     # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
>                     $item->{override} = 1;
>                     $num_override++;
>-- 
>2.17.2 (Apple Git-113)

Actions: View | Diff | Splinter Review

Attachments on bug 21495: 82359 | 82361 | 82416 | 84282 | 84485