Attachment 82394 Details for Bug 20598 – Bug 20598: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

[patch] Bug 20598: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

Bug-20598-Accruing-fines-not-closed-out-by-longove.patch (text/plain), 1.98 KB, created by Marcel de Rooy on 2018-11-16 10:50:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-11-16 10:50:31 UTC

Size: 1.98 KB

patch

obsolete

>From f2312710805b6c7cad264bca3c1ab4d4834a25a5 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 17 Apr 2018 14:11:41 -0400
>Subject: [PATCH] Bug 20598: Accruing fines not closed out by longoverdue.pl if
> WhenLostForgiveFine is not enabled
>Content-Type: text/plain; charset=utf-8
>
>Test Plan:
>1) Ensure WhenLostForgiveFine is disabled
>2) Create an overdue with a fine
>3) Mark it lost with longoverdue.pl
>4) Note it is still marked as an accruing fine
>5) Apply this patch
>6) Repeat steps 1-3
>7) Note it is no longer an accruing fine!
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>Followed the test plan and it works.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Circulation.pm | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 12460ef..ba4f63e 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3692,10 +3692,9 @@ sub LostItem{
>     if ( my $borrowernumber = $issues->{borrowernumber} ){
>         my $patron = Koha::Patrons->find( $borrowernumber );
> 
>-        if (C4::Context->preference('WhenLostForgiveFine')){
>-            my $fix = _FixOverduesOnReturn($borrowernumber, $itemnumber, 1, 0); # 1, 0 = exemptfine, no-dropbox
>-            defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!";  # zero is OK, check defined
>-        }
>+        my $fix = _FixOverduesOnReturn($borrowernumber, $itemnumber, C4::Context->preference('WhenLostForgiveFine'), 0); # 1, 0 = exemptfine, no-dropbox
>+        defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!";  # zero is OK, check defined
>+
>         if (C4::Context->preference('WhenLostChargeReplacementFee')){
>             C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}");
>             #FIXME : Should probably have a way to distinguish this from an item that really was returned.
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20598: 74377 | 75932 | 81953 | 81954 | 82391 | 82392 | 82394 | 82395 | 82396