Attachment 82440 Details for Bug 20600 – Bug 20600: (follow-up) Restore patron name fix

[patch] Bug 20600: (follow-up) Restore patron name fix

Bug-20600-follow-up-Restore-patron-name-fix.patch (text/plain), 1.67 KB, created by Andrew Isherwood on 2018-11-19 11:31:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-11-19 11:31:22 UTC

Size: 1.67 KB

patch

obsolete

>From 55fc7360fbf33abd834534135d01ddb49c9e412c Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 8 Nov 2018 11:03:37 +0000
>Subject: [PATCH] Bug 20600: (follow-up) Restore patron name fix
>
>The fix for patron name display when no first name is specified was lost
>in the rebase. This patch restores it.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 585dac4803..e4fbfcb7c1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -694,11 +694,14 @@
> 
>             // Our 'render' function for borrowerlink
>             var createPatronLink = function(data, type, row) {
>-                return '<a title="' + _("View borrower details") + '" ' +
>+                var patronLink = '<a title="' + _("View borrower details") + '" ' +
>                     'href="/cgi-bin/koha/members/moremember.pl?' +
>-                    'borrowernumber='+row.borrowernumber+'">' +
>-                    row.patron_firstname + ' ' + row.patron_surname +
>-                    '</a>';
>+                    'borrowernumber='+row.borrowernumber+'">';
>+                if ( row.patron_firstname ) {
>+                    patronLink = patronLink + row.patron_firstname + ' ';
>+                }
>+                patronLink = patronLink + row.patron_surname + '</a>';
>+                return patronLink;
>             };
> 
>             // Our 'render' function for the library name
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20600: 74640 | 74641 | 75202 | 75276 | 75734 | 75735 | 75753 | 75755 | 75844 | 75845 | 75848 | 75849 | 75850 | 75851 | 75852 | 75853 | 75854 | 75871 | 77691 | 77692 | 77693 | 77694 | 77695 | 77696 | 77697 | 78439 | 78440 | 78441 | 78442 | 78443 | 78444 | 78445 | 78446 | 78463 | 78464 | 78465 | 78466 | 78467 | 78468 | 78469 | 78470 | 79183 | 80468 | 81992 | 81993 | 82032 | 82033 | 82034 | 82035 | 82036 | 82037 | 82038 | 82039 | 82062 | 82170 | 82171 | 82432 | 82433 | 82434 | 82435 | 82436 | 82437 | 82438 | 82439 | 82440 | 82441 | 82442 | 83882 | 83887 | 84736 | 84737 | 84738 | 84739 | 84740 | 84741 | 84742 | 84743 | 84744 | 84745 | 84746 | 84747 | 84748 | 84749 | 85037 | 85038 | 85039 | 85040 | 85041 | 85042 | 85043 | 85044 | 85045 | 85046 | 85047 | 85048 | 85049 | 85050