Attachment 82445 Details for Bug 20581 – Bug 20581: Provide status_alias on IllRequest

[patch] Bug 20581: Provide status_alias on IllRequest

Bug-20581-Provide-statusalias-on-IllRequest.patch (text/plain), 1.80 KB, created by Andrew Isherwood on 2018-11-19 12:06:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-11-19 12:06:11 UTC

Size: 1.80 KB

patch

obsolete

>From 4d035af17d7f94eb07e5bee2a3e885159f520eae Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Tue, 17 Apr 2018 12:02:18 +0100
>Subject: [PATCH] Bug 20581: Provide status_alias on IllRequest
>
>This patch provides status_alias support for the Koha::Illrequest
>object.
>
>- New 'statusalias' getter method, returns the request's status_alias
>authorised value object if set, otherwise undef
>- Overloads existing 'status' method, getter/setter accessors intact,
>but setting the request's status now implicitly removes any status_alias
>that has been set
>
>Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
>---
> Koha/Illrequest.pm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index ff834f14f5..18cd57e676 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -31,6 +31,7 @@ use Koha::Email;
> use Koha::Exceptions::Ill;
> use Koha::Illcomments;
> use Koha::Illrequestattributes;
>+use Koha::AuthorisedValue;
> use Koha::Patron;
> 
> use base qw(Koha::Object);
>@@ -109,6 +110,19 @@ available for request.
> 
> =head2 Class methods
> 
>+=head3 statusalias
>+
>+=cut
>+
>+sub statusalias {
>+    my ( $self ) = @_;
>+    return $self->status_alias ?
>+        Koha::AuthorisedValue->_new_from_dbic(
>+            scalar $self->_result->status_alias
>+        ) :
>+        undef;
>+}
>+
> =head3 illrequestattributes
> 
> =cut
>@@ -142,6 +156,22 @@ sub patron {
>     );
> }
> 
>+=head3 status
>+
>+Overloaded getter/setter for request status,
>+also nullifies status_alias
>+
>+=cut
>+
>+sub status {
>+    my ( $self, $newval) = @_;
>+    if ($newval) {
>+        $self->status_alias(undef);
>+        return $self->SUPER::status($newval);
>+    }
>+    return $self->SUPER::status;
>+}
>+
> =head3 load_backend
> 
> Require "Base.pm" from the relevant ILL backend.
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20581: 74323 | 74324 | 74325 | 74326 | 74327 | 74362 | 75333 | 75334 | 75810 | 77819 | 77820 | 77821 | 77822 | 77823 | 77824 | 77825 | 77826 | 78376 | 78377 | 78378 | 78379 | 78380 | 78381 | 78382 | 78383 | 78384 | 78431 | 78515 | 78516 | 78517 | 78518 | 78519 | 78520 | 78521 | 78522 | 78523 | 80279 | 80280 | 80281 | 80282 | 80283 | 80284 | 80285 | 80286 | 80474 | 80475 | 80501 | 80503 | 80505 | 80598 | 80599 | 80600 | 82063 | 82064 | 82065 | 82066 | 82067 | 82068 | 82069 | 82070 | 82071 | 82072 | 82073 | 82074 | 82075 | 82076 | 82443 | 82444 | 82445 | 82446 | 82447 | 82448 | 82449 | 82450 | 82451 | 82452 | 82453 | 82454 | 82455 | 82456 | 82457 | 82458 | 82459 | 82460 | 82461 | 82462 | 82463 | 82464 | 82465 | 82466 | 82467 | 82468 | 82472 | 82483 | 82484 | 82485 | 82486 | 82487 | 82488 | 82489 | 82490 | 82491 | 82492 | 82493 | 82494 | 82495 | 82496 | 82733 | 84202 | 84404 | 84768 | 84770 | 84771 | 84772 | 84773 | 84774 | 84775 | 84776 | 84777 | 84778 | 84779 | 84780 | 84781 | 84782 | 84783 | 84784 | 84785 | 84791 | 84814 | 84818 | 84819 | 84844 | 84911 | 84912 | 84913 | 84914 | 84915 | 84916 | 84917 | 84918 | 84919 | 84920 | 84921 | 84922 | 84923 | 84924 | 84925 | 84926 | 84927 | 84928 | 84929 | 84930 | 84931 | 84964 | 85075 | 85076 | 85077 | 85078 | 85079 | 85080 | 85081 | 85082 | 85083 | 85084 | 85085 | 85086 | 85087 | 85088 | 85089 | 85090 | 85091 | 85092 | 85093 | 85094 | 85095 | 85096