Bugzilla – Attachment 82475 Details for
Bug 19066
Add branchcode to accountlines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19066: (QA follow-up) Remove bad and unecessary test
Bug-19066-QA-follow-up-Remove-bad-and-unecessary-t.patch (text/plain), 1.75 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-11-19 12:23:28 UTC
(
hide
)
Description:
Bug 19066: (QA follow-up) Remove bad and unecessary test
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-11-19 12:23:28 UTC
Size:
1.75 KB
patch
obsolete
>From c102ae72f8a0d157337627c37ad9907ef3fb7514 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 2 Nov 2018 14:38:56 -0400 >Subject: [PATCH] Bug 19066: (QA follow-up) Remove bad and unecessary test > >--- > t/db_dependent/Accounts.t | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > >diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t >index 3813dea6f0..b52f45817c 100644 >--- a/t/db_dependent/Accounts.t >+++ b/t/db_dependent/Accounts.t >@@ -18,7 +18,7 @@ > > use Modern::Perl; > >-use Test::More tests => 41; >+use Test::More tests => 36; > use Test::MockModule; > use Test::Warn; > >@@ -103,18 +103,6 @@ ok( $accountline->description =~ /^$description/, 'Accountline description set c > is( $accountline->note, $note, 'Accountline note set correctly for manualinvoice' ); > is( $accountline->branchcode, $branchcode, 'Accountline branchcode set correctly for manualinvoice' ); > >-# Test _FixAccountForLostAndReturned, use the accountline from the manualinvoice to test >-C4::Circulation::_FixAccountForLostAndReturned( $item->{itemnumber} ); >-my ( $accountline_fee, $accountline_payment ) = Koha::Account::Lines->search( >- { >- borrowernumber => $patron->{borrowernumber} >- } >-); >-is( $accountline_fee->accounttype, 'LR', 'Lost item fee account type updated to LR' ); >-is( $accountline_fee->amountoutstanding, '0.000000', 'Lost item fee amount outstanding updated to 0' ); >-is( $accountline_payment->accounttype, 'CR', 'Lost item fee account type is CR' ); >-is( $accountline_payment->amount, "-$amount", 'Lost item refund amount is correct' ); >-is( $accountline_payment->branchcode, $branchcode, 'Lost item refund branchcode is set correctly' ); > $dbh->do(q|DELETE FROM accountlines|); > > # Testing purge_zero_balance_fees >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19066
:
65769
|
65770
|
65771
|
67756
|
67757
|
71153
|
71154
|
71155
|
73185
|
73186
|
73187
|
73595
|
77281
|
77282
|
77283
|
78900
|
78901
|
81144
|
81145
|
81146
|
81253
|
81254
|
81255
|
81684
|
81912
|
81918
|
82047
|
82048
|
82084
|
82086
|
82087
|
82469
|
82470
|
82471
|
82473
|
82474
|
82475
|
82476
|
82477
|
82478
|
83067
|
83068
|
83069
|
83070
|
83071
|
83072
|
83073
|
83074
|
83075
|
83076
|
83077
|
83078
|
83079
|
83080
|
83081
|
83082
|
83083
|
83084
|
83275
|
83519
|
83520
|
83521
|
83522
|
83523
|
83524
|
83525
|
83526
|
83527
|
83528
|
83628