Bugzilla – Attachment 82700 Details for
Bug 21900
intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21900: Fix erroneous filter
Bug-21900-Fix-erroneous-filter.patch (text/plain), 1.53 KB, created by
Andrew Isherwood
on 2018-11-28 13:52:53 UTC
(
hide
)
Description:
Bug 21900: Fix erroneous filter
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2018-11-28 13:52:53 UTC
Size:
1.53 KB
patch
obsolete
>From 384b4763b1c4a646466eb1853ed7f238bea23969 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Wed, 28 Nov 2018 13:50:08 +0000 >Subject: [PATCH] Bug 21900: Fix erroneous filter > >Swap the filter from html to $raw. We need the browser to be able to >parse the HTML supplied by plugins. > >Test plan: >- Apply patch >- Install plugin that uses the >intranet_catalog_biblio_enhancements_toolbar_button hook, currently only https://github.com/PTFS-Europe/koha-plugin-cla-check_permissions/releases >- View the /cgi-bin/koha/catalogue/detail.pl page for an record >=> TEST: Verify that the "CLA Check Permissions" button is displaying in >the record's tool bar >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index e904dde161..cde9442200 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -1,4 +1,5 @@ > [% INCLUDE 'blocking_errors.inc' %] >+[% USE raw %] > <div id="toolbar" class="btn-toolbar"> > > [% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items || >@@ -140,7 +141,7 @@ CAN_user_serials_create_subscription ) %] > [% END %] > > [% FOREACH p IN plugins %] >- [% p.intranet_catalog_biblio_enhancements_toolbar_button | html %] >+ [% p.intranet_catalog_biblio_enhancements_toolbar_button | $raw %] > [% END %] > > </div> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21900
: 82700