Attachment 82731 Details for Bug 21753 – Bug 21753: DBRev to remove the field from the database

[patch] Bug 21753: DBRev to remove the field from the database

Bug-21753-DBRev-to-remove-the-field-from-the-datab.patch (text/plain), 2.14 KB, created by Marcel de Rooy on 2018-11-29 12:02:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-11-29 12:02:03 UTC

Size: 2.14 KB

patch

obsolete

>From d67d467897957a5f021c0cd384456addd3f85784 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 2 Nov 2018 10:04:46 +0000
>Subject: [PATCH] Bug 21753: DBRev to remove the field from the database
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> installer/data/mysql/atomicupdate/bug_21753.perl | 10 ++++++++++
> installer/data/mysql/kohastructure.sql           |  1 -
> 2 files changed, 10 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_21753.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_21753.perl b/installer/data/mysql/atomicupdate/bug_21753.perl
>new file mode 100644
>index 0000000..f5e5d44
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_21753.perl
>@@ -0,0 +1,10 @@
>+$DBversion = 'XXX';  # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+    if( column_exists( 'issuingrules', 'chargename' ) ) {
>+        $dbh->do( "ALTER TABLE issuingrules DROP chargename" );
>+    }
>+
>+    # Always end with this (adjust the bug info)
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 21753: Drop chargename from issuingrules )\n";
>+}
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index c3c9570..82ba696 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -872,7 +872,6 @@ CREATE TABLE `issuingrules` ( -- circulation and fine rules
>   `chargeperiod` int(11) default NULL, -- how often the fine amount is charged
>   `chargeperiod_charge_at` tinyint(1) NOT NULL DEFAULT '0', -- Should fine be given at the start ( 1 ) or the end ( 0 ) of the period
>   `accountsent` int(11) default NULL, -- not used? always NULL
>-  `chargename` varchar(100) default NULL, -- not used? always NULL
>   `maxissueqty` int(4) default NULL, -- total number of checkouts allowed
>   `maxonsiteissueqty` int(4) default NULL, -- total number of on-site checkouts allowed
>   `issuelength` int(4) default NULL, -- length of checkout in the unit set in issuingrules.lengthunit
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21753: 81876 | 81877 | 82715 | 82716 | 82730 | 82731 | 82732