Bugzilla – Attachment 82779 Details for
Bug 21716
Item Search hangs when \ exists in MARC fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21716: Item Search hangs when \ exists in MARC fields
Bug-21716-Item-Search-hangs-when--exists-in-MARC-f.patch (text/plain), 2.05 KB, created by
Martin Renvoize (ashimema)
on 2018-11-30 12:41:59 UTC
(
hide
)
Description:
Bug 21716: Item Search hangs when \ exists in MARC fields
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-11-30 12:41:59 UTC
Size:
2.05 KB
patch
obsolete
>From fb46ab6cfbc21b84338f0e57a6796a6b0d081273 Mon Sep 17 00:00:00 2001 >From: Claire Gravely <claire.gravely@bsz-bw.de> >Date: Fri, 30 Nov 2018 10:38:33 +0000 >Subject: [PATCH] Bug 21716: Item Search hangs when \ exists in MARC fields > >When there are \ (backslashes) in MARC records the item search hangs >when trying to load the page the record should appear on. It gets stuck >on processing. This patch fixes this issue. > >To Test: >1. Create or edit a biblio and add in \ to the publisher field. eg: >Narr\Francke\Attempto >2. Make sure this biblio has items attached that you can search for >3. Do an item search which would include the edited biblio in the >results > - a general search for a home library or shelving location will work >4. Try to load All results (or the page with the edited biblio) > The page will hang :-( >5. Apply patch >6. Perform the item search again >7. Try to load All results > The page will load :-) > >Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/includes/catalogue/itemsearch_item.json.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc >index 45b43f647b..994ca244cb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc >@@ -1,8 +1,9 @@ > [%- USE Branches -%] > [%- USE Koha -%] > [% USE AuthorisedValues %] >+[% USE JSON.Escape %] > [%- biblio = item.biblio -%] >-[%- biblioitem = item.biblioitem -%] >+[%- biblioitem = item.biblioitem | json -%] > [ > "[% FILTER escape_quotes = replace('"', '\"') ~%] > <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio.biblionumber | uri %]" title="Go to record detail page">[% biblio.title | html %]</a>[% IF ( Koha.Preference( 'marcflavour' ) == 'UNIMARC' && biblio.author ) %] by[% END %] [% biblio.author | html %] >-- >2.19.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21716
:
82776
|
82779
|
82980
|
83147
|
88790
|
91780
|
91807