Bugzilla – Attachment 82808 Details for
Bug 21728
Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee
Bug-21728-Use-KohaAccount-adddebit-in-ChargeReserv.patch (text/plain), 1.81 KB, created by
Martin Renvoize (ashimema)
on 2018-11-30 19:48:00 UTC
(
hide
)
Description:
Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-11-30 19:48:00 UTC
Size:
1.81 KB
patch
obsolete
>From 5797967de7e38642ced35211c137204a2f092546 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 1 Nov 2018 11:08:51 +0000 >Subject: [PATCH] Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee > >--- > C4/Reserves.pm | 26 +++++++++++--------------- > 1 file changed, 11 insertions(+), 15 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 9e85854012..da30b13e74 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -567,24 +567,20 @@ sub GetOtherReserves { > > sub ChargeReserveFee { > my ( $borrowernumber, $fee, $title ) = @_; >- > return if !$fee || $fee == 0; # the last test is needed to include 0.00 >- >- my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; >- my $nextacctno = C4::Accounts::getnextacctno($borrowernumber); >- >- Koha::Account::Line->new( >+ Koha::Account->new( { patron_id => $borrowernumber } )->add_debit( > { >- borrowernumber => $borrowernumber, >- accountno => $nextacctno, >- date => dt_from_string(), >- amount => $fee, >- description => "Reserve Charge - $title", >- accounttype => 'Res', >- amountoutstanding => $fee, >- branchcode => $branchcode >+ amount => $fee, >+ description => "Reserve Charge - " . $title, >+ note => undef, >+ user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : 0, >+ library_id => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef, >+ sip => undef, >+ invoice_type => undef, >+ type => 'reserve', >+ item_id => undef > } >- )->store(); >+ ); > } > > =head2 GetReserveFee >-- >2.19.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21728
:
81791
|
81881
|
82808
|
82809
|
84278
|
84279
|
85171
|
85172
|
86032