Attachment 82811 Details for Bug 21896 – [18.05.x] Bug 21896: Add unit tests for Koha::Account::normalize_balance

[patch] [18.05.x] Bug 21896: Add unit tests for Koha::Account::normalize_balance

1805x-Bug-21896-Add-unit-tests-for-KohaAccountnorm.patch (text/plain), 6.62 KB, created by Tomás Cohen Arazi (tcohen) on 2018-11-30 20:11:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-11-30 20:11:38 UTC

Size: 6.62 KB

patch

obsolete

>From 4521971eca53819779c89e877d6251ae8cce9add Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 27 Nov 2018 17:06:20 -0300
>Subject: [PATCH] [18.05.x] Bug 21896: Add unit tests for
> Koha::Account::normalize_balance
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/Account.t | 123 +++++++++++++++++++++++++++++++++-
> 1 file changed, 122 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Account.t b/t/db_dependent/Koha/Account.t
>index 9ed615e880..ceda544e09 100755
>--- a/t/db_dependent/Koha/Account.t
>+++ b/t/db_dependent/Koha/Account.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 3;
>+use Test::More tests => 4;
> 
> use Koha::Account;
> use Koha::Account::Lines;
>@@ -191,3 +191,124 @@ subtest 'add_credit() tests' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>+subtest 'normalize_balance' => sub {
>+
>+    plan tests => 3;
>+
>+    subtest 'more credit than debit' => sub {
>+
>+        plan tests => 6;
>+
>+        $schema->storage->txn_begin;
>+
>+        my $patron  = $builder->build_object({ class => 'Koha::Patrons' });
>+        my $account = $patron->account;
>+
>+        # Add Credits
>+        $account->add_credit({ amount => 1 });
>+        $account->add_credit({ amount => 2 });
>+        $account->add_credit({ amount => 3 });
>+        $account->add_credit({ amount => 4 });
>+        $account->add_credit({ amount => 5 });
>+
>+        # Add Debits TODO: replace for calls to add_debit when time comes
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 1 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 2, amountoutstanding => 2 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 3, amountoutstanding => 3 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 4, amountoutstanding => 4 })->store;
>+
>+        # Paid Off
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0 })->store;
>+
>+        is( $account->balance(), -5, "Account balance is -5" );
>+        is( $account->outstanding_debits->total_outstanding, 10, 'Outstanding debits sum 10' );
>+        is( $account->outstanding_credits->total_outstanding, -15, 'Outstanding credits sum -15' );
>+
>+        $account->normalize_balance();
>+
>+        is( $account->balance(), -5, "Account balance is -5" );
>+        is( $account->outstanding_debits->total_outstanding, 0, 'No outstanding debits' );
>+        is( $account->outstanding_credits->total_outstanding, -5, 'Outstanding credits sum -5' );
>+
>+        $schema->storage->txn_rollback;
>+    };
>+
>+    subtest 'same debit than credit' => sub {
>+
>+        plan tests => 6;
>+
>+        $schema->storage->txn_begin;
>+
>+        my $patron  = $builder->build_object({ class => 'Koha::Patrons' });
>+        my $account = $patron->account;
>+
>+        # Add Credits
>+        $account->add_credit({ amount => 1 });
>+        $account->add_credit({ amount => 2 });
>+        $account->add_credit({ amount => 3 });
>+        $account->add_credit({ amount => 4 });
>+
>+        # Add Debits TODO: replace for calls to add_debit when time comes
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 1 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 2, amountoutstanding => 2 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 3, amountoutstanding => 3 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 4, amountoutstanding => 4 })->store;
>+
>+        # Paid Off
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0 })->store;
>+
>+        is( $account->balance(), 0, "Account balance is 0" );
>+        is( $account->outstanding_debits->total_outstanding, 10, 'Outstanding debits sum 10' );
>+        is( $account->outstanding_credits->total_outstanding, -10, 'Outstanding credits sum -10' );
>+
>+        $account->normalize_balance();
>+
>+        is( $account->balance(), 0, "Account balance is 0" );
>+        is( $account->outstanding_debits->total_outstanding, 0, 'No outstanding debits' );
>+        is( $account->outstanding_credits->total_outstanding, 0, 'Outstanding credits sum 0' );
>+
>+        $schema->storage->txn_rollback;
>+    };
>+
>+    subtest 'more debit than credit' => sub {
>+
>+        plan tests => 6;
>+
>+        $schema->storage->txn_begin;
>+
>+        my $patron  = $builder->build_object({ class => 'Koha::Patrons' });
>+        my $account = $patron->account;
>+
>+        # Add Credits
>+        $account->add_credit({ amount => 1 });
>+        $account->add_credit({ amount => 2 });
>+        $account->add_credit({ amount => 3 });
>+        $account->add_credit({ amount => 4 });
>+
>+        # Add Debits TODO: replace for calls to add_debit when time comes
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 1 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 2, amountoutstanding => 2 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 3, amountoutstanding => 3 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 4, amountoutstanding => 4 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 5, amountoutstanding => 5 })->store;
>+
>+        # Paid Off
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0 })->store;
>+        Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0 })->store;
>+
>+        is( $account->balance(), 5, "Account balance is 5" );
>+        is( $account->outstanding_debits->total_outstanding, 15, 'Outstanding debits sum 15' );
>+        is( $account->outstanding_credits->total_outstanding, -10, 'Outstanding credits sum -10' );
>+
>+        $account->normalize_balance();
>+
>+        is( $account->balance(), 5, "Account balance is 5" );
>+        is( $account->outstanding_debits->total_outstanding, 5, 'Outstanding debits sum 5' );
>+        is( $account->outstanding_credits->total_outstanding, 0, 'Outstanding credits sum 0' );
>+
>+        $schema->storage->txn_rollback;
>+    };
>+};
>-- 
>2.19.2

Actions: View | Diff | Splinter Review

Attachments on bug 21896: 82684 | 82685 | 82688 | 82689 | 82690 | 82691 | 82692 | 82701 | 82702 | 82703 | 82720 | 82721 | 82722 | 82735 | 82736 | 82737 | 82738 | 82739 | 82740 | 82742 | 82811 | 82812 | 82813 | 82814 | 82815 | 82820