Bugzilla – Attachment 82852 Details for
Bug 21944
Fix waiting holds at wrong location bug
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21944: Test for Circulation.pm
Bug-21944-Test-for-Circulationpm.patch (text/plain), 1.91 KB, created by
Christopher Brannon
on 2018-12-05 00:07:21 UTC
(
hide
)
Description:
Bug 21944: Test for Circulation.pm
Filename:
MIME Type:
Creator:
Christopher Brannon
Created:
2018-12-05 00:07:21 UTC
Size:
1.91 KB
patch
obsolete
>From 07da6cdf7dba625efa1882ed0be4028175696e90 Mon Sep 17 00:00:00 2001 >From: Christopher Brannon <cbrannon@cdalibrary.org> >Date: Wed, 5 Dec 2018 00:05:47 +0000 >Subject: [PATCH] Bug 21944: Test for Circulation.pm > >--- > t/db_dependent/Circulation.t | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 93f62571c6..e2ae551166 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -40,6 +40,7 @@ use Koha::Patrons; > use Koha::Subscriptions; > use Koha::Account::Lines; > use Koha::Account::Offsets; >+use Koha::Items; > > my $schema = Koha::Database->schema; > $schema->storage->txn_begin; >@@ -2365,7 +2366,7 @@ subtest '_FixOverduesOnReturn' => sub { > }; > > subtest 'Set waiting flag' => sub { >- plan tests => 4; >+ plan tests => 8; > > my $library_1 = $builder->build( { source => 'Branch' } ); > my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } ); >@@ -2413,6 +2414,17 @@ subtest 'Set waiting flag' => sub { > is( $hold->found, 'W', 'Hold is waiting' ); > ( $status ) = CheckReserves($item->{itemnumber}); > is( $status, 'Waiting', 'Now the hold is waiting'); >+ >+ #Bug 21944 - Waiting transfer checked in at branch other than pickup location >+ >+ $do_transfer = 1; >+ AddReturn( $item->{barcode}, $library_1->{branchcode} ); >+ ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id ); >+ $hold = Koha::Holds->find( $reserve_id ); >+ is( $hold->found, 'T', 'Hold is in transit' ); >+ is( $hold->branchcode, $library_2->{branchcode}, 'Item destination matches the pickup branch'); >+ ( $status ) = CheckReserves($item->{itemnumber}); >+ is( $status, 'Reserved', 'Now the hold is set back to reserved'); > }; > > subtest 'CanBookBeIssued | is_overdue' => sub { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21944
:
82848
|
82852
|
83144
|
84752
|
84753
|
84754
|
92609
|
92610
|
94220
|
94221
|
95950
|
95951
|
95952
|
98528
|
98529
|
98530
|
99165
|
99166
|
99167