Bugzilla – Attachment 82916 Details for
Bug 21910
Koha::Library::Groups->get_search_groups should return the groups, not the children
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21910: Remove duplicated lines in tests
Bug-21910-Remove-duplicated-lines-in-tests.patch (text/plain), 1.55 KB, created by
Jonathan Druart
on 2018-12-06 15:53:55 UTC
(
hide
)
Description:
Bug 21910: Remove duplicated lines in tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-12-06 15:53:55 UTC
Size:
1.55 KB
patch
obsolete
>From 98f36d43266a7f700f59553a13806fb58f99987d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Dec 2018 12:52:54 -0300 >Subject: [PATCH] Bug 21910: Remove duplicated lines in tests > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/LibraryGroups.t | 8 -------- > 1 file changed, 8 deletions(-) > >diff --git a/t/db_dependent/LibraryGroups.t b/t/db_dependent/LibraryGroups.t >index 02d20651e1..eb800dd1ad 100644 >--- a/t/db_dependent/LibraryGroups.t >+++ b/t/db_dependent/LibraryGroups.t >@@ -122,14 +122,6 @@ subtest 'Koha::Library::Group->get_search_groups' => sub { > is_deeply( $groups[0]->unblessed, $groupA->unblessed, 'Get search groups opac should return enabled group' ); > @groups = Koha::Library::Groups->get_search_groups({ interface => 'staff' }); > is_deeply( $groups[0]->unblessed, $groupB->unblessed, 'Get search groups staff should return enabled group' ); >- >- # TODO This is not implemented because not used yet >- # ->has_child only works with libraries >- #is( $groupA->has_child( $groupA1 ), 1, 'groupA1 should be condidered as a child of groupA' ); >- >- # FIXME At the time of writing this test fails because the ->children methods does not return more than 1 level of depth >- # See Bug 15707 comments 166-170+ >- #is( $groupA->has_child( $groupA1_library2->branchcode ), 1, 'groupA1_library2 should be considered as a child of groupA (it is a grandchild)' ); > }; > > my $groupX = Koha::Library::Group->new( { title => "Group X" } )->store(); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21910
:
82741
|
82755
|
82766
|
82915
| 82916 |
82917