Bugzilla – Attachment 82923 Details for
Bug 21904
Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21904: Hide libraries outside of the group in the header
Bug-21904-Hide-libraries-outside-of-the-group-in-t.patch (text/plain), 2.06 KB, created by
Jonathan Druart
on 2018-12-06 17:00:08 UTC
(
hide
)
Description:
Bug 21904: Hide libraries outside of the group in the header
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-12-06 17:00:08 UTC
Size:
2.06 KB
patch
obsolete
>From b5861e14b35e191090b4bac406705c85bf2f58e4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Dec 2018 13:58:44 -0300 >Subject: [PATCH] Bug 21904: Hide libraries outside of the group in the header > >Fix typo > >To test: >1 - Create a library group with two libraries >2 - Enable hiding patron info for that group >3 - Find or create a patron at one of those libraries without >view_borrower_infos_from_any_libraries permission (but with staff side >permission) >4 - Sign in as that staff person >5 - Click 'Patrons' >6 - Click the [+] to expand search options >7 - Set the 'Library' dropdown to a library outside of the group >8 - Search >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index b56fab9a33..806fc710a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -85,18 +85,12 @@ > > <p> > <label for="branchcode">Library: </label> >- [% SET branches = Branches.all( selected => branchcode_filter, only_my_group => 1 ) %] >+ [% SET branches = Branches.all( selected => branchcode_filter, only_from_group => 1 ) %] > <select name="branchcode_filter" id="branchcode"> > [% IF branches.size != 1 %] > <option value="">Any</option> > [% END %] >- [% FOREACH b IN branches %] >- [% IF b.selected %] >- <option value="[% b.branchcode | html %]" selected="selected">[% b.branchname | html %]</option> >- [% ELSE %] >- <option value="[% b.branchcode | html %]">[% b.branchname | html %]</option> >- [% END %] >- [% END %] >+ [% PROCESS options_for_libraries libraries => branches %] > </select> > </p> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21904
:
82923
|
83018
|
85222
|
85234
|
85235