Attachment 8298 Details for Bug 7732 – [SIGNED-OFF] Bug 7732: Restoring "More lists" in the Add-to combo of OPAC Search Results

[patch] [SIGNED-OFF] Bug 7732: Restoring "More lists" in the Add-to combo of OPAC Search Results

SIGNED-OFF-Bug-7732-Restoring-More-lists-in-the-Ad.patch (text/plain), 2.83 KB, created by Nicole C. Engard on 2012-03-19 15:14:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-03-19 15:14:22 UTC

Size: 2.83 KB

patch

obsolete

>From 92982a4b000d939487bb73e5090222672e7d8a13 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 19 Mar 2012 14:11:35 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 7732: Restoring "More lists" in the Add-to combo of OPAC Search Results
>
>1) More lists -> More Lists in order to be consistent with context.
>2) More Lists is put just before New List at the end of the combo list. (More logical place than between your and public lists.)
>3) More Lists is only shown when the number of private or public lists exceeds 9; this is a pragmatic and hard-coded approach for now. Only if there are exactly 10 lists, this does not really add a list. But who cares about that?
>4) Resolves a potential bug with an [% END %] at the wrong place. Moved it after the finishing optgroup tag.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>
>Performed a search in the OPAC without the patch and More Lists does
>not appear. Applied patch and perfomred OPAC search again and the More
>Lists option reappears. Signed off.
>---
> .../opac-tmpl/prog/en/modules/opac-results.tt      |    8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>index 60f1ae8..c8a3926 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>@@ -105,10 +105,12 @@ $(document).ready(function(){
>     [% END %][% IF ( virtualshelves ) %][% IF ( loggedinusername ) %][% IF ( addbarshelves ) %]
>     param1 += "<optgroup label=\""+_("Your Lists:")+"\">";[% FOREACH addbarshelvesloo IN addbarshelvesloop %]
>     param1 += "<option id=\"s[% addbarshelvesloo.shelfnumber %]\" value=\"addtolist\">[% addbarshelvesloo.shelfname |html %]<\/option>";[% END %]
>-    [% IF ( bartotal ) %]param1 += "<option value=\"morelists\">[ "+_("More lists")+" ]<\/option>";[% END %]
>     param1 += "<\/optgroup>";[% END %]
>-    [% IF ( addpubshelves ) %]param1 += "<optgroup label=\""+_("Public Lists:")+"\">"[% FOREACH addpubshelvesloo IN addpubshelvesloop %]+"<option id=\"s[% addpubshelvesloo.shelfnumber %]\" value=\"addtolist\">[% addpubshelvesloo.shelfname |html %]<\/option>"[% END %];[% END %]
>-    param1 += "<\/optgroup>";
>+    [% IF ( addpubshelves ) %]param1 += "<optgroup label=\""+_("Public Lists:")+"\">"[% FOREACH addpubshelvesloo IN addpubshelvesloop %]+"<option id=\"s[% addpubshelvesloo.shelfnumber %]\" value=\"addtolist\">[% addpubshelvesloo.shelfname |html %]<\/option>"[% END %];
>+    param1 += "<\/optgroup>";[% END %]
>+    [% IF ( addbarshelvesloop.size>9 || addpubshelvesloop.size>9 ) %]
>+        param1 += "<option value=\"morelists\">[ "+_("More Lists")+" ]<\/option>";
>+    [% END %]
>     param1 += "<option value=\"newlist\">[ "+_("New List")+" ]<\/option>";
>     [% END %]
>     [% END %]
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 7732: 8278 | 8298