Attachment 83048 Details for Bug 21969 – Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases

[patch] Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases

Bug-21969-Fix-KohaAccount-outstanding-matching-the.patch (text/plain), 1.38 KB, created by Kyle M Hall (khall) on 2018-12-11 15:01:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-12-11 15:01:10 UTC

Size: 1.38 KB

patch

obsolete

>From a1943c81d584df20416880d34b0d8061ae832a07 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 6 Dec 2018 15:59:10 -0300
>Subject: [PATCH] Bug 21969: Fix Koha::Account->outstanding_* matching the
> opposite on pathological cases
>
>This patch makes outstanding_* methods be safe regarding pathological
>account lines that get converted into another type because of the value
>of amountoutstanding
>
>To test:
>- Run:
>  $ kshell
> k$ prove t/db_dependent/Koha/Account.t
>=> FAIL: Tests fail because pathological account lines are wrongly
>picked.
>- Apply this patch
>- Run:
> k$ prove t/db_dependent/Koha/Account.t
>=>SUCCESS: All green!
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Account.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/Koha/Account.pm b/Koha/Account.pm
>index 5630f4130e..4b68f2aaa9 100644
>--- a/Koha/Account.pm
>+++ b/Koha/Account.pm
>@@ -430,6 +430,7 @@ sub outstanding_debits {
> 
>     my $lines = $self->lines->search(
>         {
>+            amount            => { '>' => 0 },
>             amountoutstanding => { '>' => 0 }
>         }
>     );
>@@ -448,6 +449,7 @@ sub outstanding_credits {
> 
>     my $lines = $self->lines->search(
>         {
>+            amount            => { '<' => 0 },
>             amountoutstanding => { '<' => 0 }
>         }
>     );
>-- 
>2.17.2 (Apple Git-113)

Actions: View | Diff | Splinter Review

Attachments on bug 21969: 82939 | 82940 | 83011 | 83012 | 83047 | 83048