Bugzilla – Attachment 83060 Details for
Bug 21984
Unable to load second page of results for reports with reused parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21984: Pass param_name in ppagination URL
Bug-21984-Pass-paramname-in-ppagination-URL.patch (text/plain), 1.70 KB, created by
Lucas Gass (lukeg)
on 2018-12-11 20:10:32 UTC
(
hide
)
Description:
Bug 21984: Pass param_name in ppagination URL
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2018-12-11 20:10:32 UTC
Size:
1.70 KB
patch
obsolete
>From ff4da6f03c352e226cbe998a32fb1e9d634c46ef Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 11 Dec 2018 15:15:57 +0000 >Subject: [PATCH] Bug 21984: Pass param_name in ppagination URL >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: > 1 - Create a report like: > SELECT <<cat>>,<<dog>>,<<cat>> FROM items > 2 - Run the report, enter 'CATS' and 'DOGS' > 3 - Get results LIKE "CAT | DOG | CAT" > 4 - Try to go to page 2 > 5 - FAIL! (last column is blank) > 6 - Apply patch > 7 - Run the repot, enter 'CATS' and 'DOGS' > 8 - Verify first page looks right > 9 - Go to page 2 >10 - Results are correct! > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: âLucas Gassâ <lucas@bywatersolutions.com> >--- > reports/guided_reports.pl | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 4a0e405..24dd108 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -829,9 +829,13 @@ elsif ($phase eq 'Run this report'){ > > my $totpages = int($total/$limit) + (($total % $limit) > 0 ? 1 : 0); > my $url = "/cgi-bin/koha/reports/guided_reports.pl?reports=$report_id&phase=Run%20this%20report&limit=$limit"; >+ if (@param_names) { >+ $url = join('&param_name=', $url, map { URI::Escape::uri_escape_utf8($_) } @param_names); >+ } > if (@sql_params) { > $url = join('&sql_params=', $url, map { URI::Escape::uri_escape_utf8($_) } @sql_params); > } >+ > $template->param( > 'results' => \@rows, > 'allresults' => \@allrows, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21984
:
83051
|
83057
|
83060
|
83140