Bugzilla – Attachment 83131 Details for
Bug 21990
No background color for div.error, must be .alert
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21990: Replace dialog .error with .alert
Bug-21990-Replace-dialog-error-with-alert.patch (text/plain), 2.19 KB, created by
Jonathan Druart
on 2018-12-12 15:24:10 UTC
(
hide
)
Description:
Bug 21990: Replace dialog .error with .alert
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-12-12 15:24:10 UTC
Size:
2.19 KB
patch
obsolete
>From adbab0d4ed90ba13590cec4111e14aa777bf8185 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 12 Dec 2018 12:22:47 -0300 >Subject: [PATCH] Bug 21990: Replace dialog .error with .alert > ><div class="dialog error"> will display a div without background color, the correct class is "dialog alert". > >https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages > >Test plan: >Hit /cgi-bin/koha/acqui/parcel.pl >Notice the background color change with and without this patch >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index b689192bbb..7887d1fb64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -64,7 +64,7 @@ > [% END %] > > [% IF (error_cancelling_receipt) %] >- <div class="dialog error"> >+ <div class="dialog alert"> > Cannot cancel receipt. Possible reasons : > <ul> > <li> >@@ -82,7 +82,7 @@ > [% END %] > > [% IF error_invoice_not_known %] >- <div class="dialog error"> >+ <div class="dialog alert"> > The invoice referenced by this invoiceid does not exist. > </div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >index 0e8818e434..82d3e725da 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >@@ -30,7 +30,7 @@ > [% ELSIF message.type == 'warning' %] > <div class="dialog alert"> > [% ELSIF message.type == 'error' %] >- <div class="dialog error" style="margin:auto;"> >+ <div class="dialog alert" style="margin:auto;"> > [% END %] > [% IF message.code == 'biblio_not_exists' %] > The biblionumber [% message.biblionumber | html %] does not exist in the database. >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21990
:
83131
|
83239
|
83565