Attachment 83140 Details for Bug 21984 – Bug 21984: Pass param_name in pagination URL

[patch] Bug 21984: Pass param_name in pagination URL

Bug-21984-Pass-paramname-in-pagination-URL.patch (text/plain), 1.78 KB, created by Jonathan Druart on 2018-12-12 16:39:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-12-12 16:39:44 UTC

Size: 1.78 KB

patch

obsolete

>From d9be84e7ebc5953366086494957bb875a7b3cd94 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 11 Dec 2018 15:15:57 +0000
>Subject: [PATCH] Bug 21984: Pass param_name in pagination URL
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To test:
> 1 - Create a report like:
>    SELECT <<cat>>,<<dog>>,<<cat>> FROM items
> 2 - Run the report, enter 'CATS' and 'DOGS'
> 3 - Get results LIKE "CAT | DOG | CAT"
> 4 - Try to go to page 2
> 5 - FAIL! (last column is blank)
> 6 - Apply patch
> 7 - Run the repot, enter 'CATS' and 'DOGS'
> 8 - Verify first page looks right
> 9 - Go to page 2
>10 - Results are correct!
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: âLucas Gassâ <lucas@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> reports/guided_reports.pl | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index 4a0e40513d..24dd1081dc 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -829,9 +829,13 @@ elsif ($phase eq 'Run this report'){
> 
>             my $totpages = int($total/$limit) + (($total % $limit) > 0 ? 1 : 0);
>             my $url = "/cgi-bin/koha/reports/guided_reports.pl?reports=$report_id&amp;phase=Run%20this%20report&amp;limit=$limit";
>+            if (@param_names) {
>+                $url = join('&amp;param_name=', $url, map { URI::Escape::uri_escape_utf8($_) } @param_names);
>+            }
>             if (@sql_params) {
>                 $url = join('&amp;sql_params=', $url, map { URI::Escape::uri_escape_utf8($_) } @sql_params);
>             }
>+
>             $template->param(
>                 'results' => \@rows,
>                 'allresults' => \@allrows,
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21984: 83051 | 83057 | 83060 | 83140