Bugzilla – Attachment 83155 Details for
Bug 21991
Displaying more rows on report results does not work for reports with parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21991: Pass param names to report limit tool
Bug-21991-Pass-param-names-to-report-limit-tool.patch (text/plain), 1.52 KB, created by
Martin Renvoize (ashimema)
on 2018-12-13 12:48:49 UTC
(
hide
)
Description:
Bug 21991: Pass param names to report limit tool
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-12-13 12:48:49 UTC
Size:
1.52 KB
patch
obsolete
>From a1665490425b82204cfb26676446d1689f5a57ca Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 12 Dec 2018 16:16:50 +0000 >Subject: [PATCH] Bug 21991: Pass param names to report limit tool > >To test: >1 - Define a report like: >SELECT barcode, itemnumber >FROM items >WHERE (homebranch = <<Branch|branches>> AND 0 ) OR ><<Branch|branches>>=<<Branch|branches>> >2 - Run it, you get results >3 - Select 'Rows to display' 50 >4 - No results >5 - Apply patch >6 - Run report >7 - Change display rows >8 - Results remain! > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 6c551b0697..8a219131c3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -710,6 +710,9 @@ canned reports and writing custom SQL reports.</p> > [% FOREACH p IN sql_params %] > <input type="hidden" name="sql_params" value="[% p | html %]"/> > [% END %] >+ [% FOREACH n IN param_names %] >+ <input type="hidden" name="param_name" value="[% n | html %]"/> >+ [% END %] > > <label for="limit">Rows per page: </label> > <select name="limit" id="limit"> >-- >2.19.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21991
:
83138
|
83141
| 83155