Bugzilla – Attachment 83178 Details for
Bug 21973
CAS URL escaped twice, preventing login
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21973: Do not url escape casServerUrl
Bug-21973-Do-not-url-escape-casServerUrl.patch (text/plain), 1.95 KB, created by
Martin Renvoize (ashimema)
on 2018-12-13 16:08:29 UTC
(
hide
)
Description:
Bug 21973: Do not url escape casServerUrl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-12-13 16:08:29 UTC
Size:
1.95 KB
patch
obsolete
>From 6493109d9baa424fabb73ad29e9ea648104c4b21 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 7 Dec 2018 10:26:02 -0300 >Subject: [PATCH] Bug 21973: Do not url escape casServerUrl > >It is already escaped correctly in >C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape > >Note that shibbolethLoginUrl is not and must be url escaped in template >("be consistent, they said") > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index 71edf3c7ce..d8aeabec78 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -97,7 +97,7 @@ > [% IF ( casAuthentication ) %] > [% IF ( shibbolethAuthentication ) %] > [% IF ( casServerUrl ) %] >- <p><a href="[% casServerUrl | url %]">Please click here to log in.</a><p> >+ <p><a href="[% casServerUrl | $raw %]">Please click here to log in.</a><p> > [% END %] > > [% IF ( casServersLoop ) %] >@@ -117,7 +117,7 @@ > [% END %] > > [% IF ( casServerUrl ) %] >- <p><a href="[% casServerUrl | url %]">If you have a CAS account, please click here to log in.</a><p> >+ <p><a href="[% casServerUrl | $raw %]">If you have a CAS account, please click here to log in.</a><p> > [% END %] > > [% IF ( casServersLoop ) %] >-- >2.19.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21973
:
82978
|
83022
|
83169
| 83178