Attachment 83192 Details for Bug 11492 – Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue

[patch] Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue

Bug-11492-follow-up-Dont-pass-publisheddatetext-pa.patch (text/plain), 2.13 KB, created by Aleisha Amohia on 2018-12-14 01:59:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2018-12-14 01:59:02 UTC

Size: 2.13 KB

patch

obsolete

>From 709087fceea444d855420d0b2fbe9b6faf8b3e18 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Fri, 14 Dec 2018 02:05:36 +0000
>Subject: [PATCH] Bug 11492: (follow-up) Don't pass publisheddatetext param to
> NewIssue
>
>I have removed publisheddatetext as a param from my patch, but only in
>the places where my patch added it. Any other instance already existed
>before my patch.
>---
> C4/Serials.pm                 | 2 +-
> serials/serials-collection.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 570c947..e6b51d8 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -1163,7 +1163,7 @@ sub ModSerialStatus {
>                     WHERE  subscriptionid = ?";
>         $sth = $dbh->prepare($query);
>         $sth->execute( $newlastvalue1, $newlastvalue2, $newlastvalue3, $newinnerloop1, $newinnerloop2, $newinnerloop3, $subscriptionid );
>-        NewIssue( $newserialseq, $subscriptionid, $subscription->{'biblionumber'}, 1, $nextpubdate, $nextpubdate, $publisheddatetext, $notes, $routingnotes );
>+        NewIssue( $newserialseq, $subscriptionid, $subscription->{'biblionumber'}, 1, $nextpubdate, $nextpubdate, undef, $notes, $routingnotes );
>         # check if an alert must be sent... (= a letter is defined & status became "arrived"
>         if ( $subscription->{letter} && $status == ARRIVED && $oldstatus != ARRIVED ) {
>             require C4::Letters;
>diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl
>index 39e08f1..eb7336b 100755
>--- a/serials/serials-collection.pl
>+++ b/serials/serials-collection.pl
>@@ -88,7 +88,7 @@ if($op eq 'gennext' && @subscriptionid){
>              my $planneddate = $date_received_today ? dt_from_string : $nextpublisheddate;
>              ## Creating the new issue
>              NewIssue( $newserialseq, $subscriptionid, $subscription->{'biblionumber'},
>-                     1, $planneddate, $nextpublisheddate, $issue->{publisheddatetext},
>+                     1, $planneddate, $nextpublisheddate, undef,
>                      $issue->{notes}, $issue->{routingnotes} );
> 
>              ## Updating the subscription seq status
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 11492: 82945 | 82946 | 83036 | 83192 | 89675 | 89676 | 90214 | 90215