Bugzilla – Attachment 8322 Details for
Bug 2505
Omnibus: Enable Perl warnings in all modules and scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 2505 : Switch on warnings in circ/returns.pl
Bug-2505--Switch-on-warnings-in-circreturnspl.patch (text/plain), 1.19 KB, created by
Chris Cormack
on 2012-03-20 00:49:15 UTC
(
hide
)
Description:
Bug 2505 : Switch on warnings in circ/returns.pl
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2012-03-20 00:49:15 UTC
Size:
1.19 KB
patch
obsolete
>From d0e3c9bc9a793b04609fa8848ac0220f5bd5c131 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 15 Jun 2011 12:15:14 +0100 >Subject: [PATCH] Bug 2505 : Switch on warnings in circ/returns.pl > >Removed a compile time warning caused by a void context >in a bit of too clever obscure code >--- > circ/returns.pl | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index e142117..43b50fe 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -27,7 +27,7 @@ script to execute returns of books > =cut > > use strict; >-#use warnings; FIXME - Bug 2505 >+use warnings; > > use CGI; > use C4::Context; >@@ -223,7 +223,8 @@ if ($barcode) { > # > ( $returned, $messages, $issueinformation, $borrower ) = > AddReturn( $barcode, $userenv_branch, $exemptfine, $dropboxmode); # do the return >- my $homeorholdingbranchreturn = C4::Context->preference('HomeOrHoldingBranchReturn') or 'homebranch'; >+ my $homeorholdingbranchreturn = C4::Context->preference('HomeOrHoldingBranchReturn'); >+ $homeorholdingbranchreturn ||= 'homebranch'; > > # get biblio description > my $biblio = GetBiblioFromItemNumber($itemnumber); >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2505
:
686
|
687
|
688
|
689
|
690
|
691
|
692
|
693
|
694
|
695
|
696
|
697
|
698
|
699
|
700
|
701
|
702
|
703
|
704
|
705
|
706
|
707
|
708
|
709
|
2223
|
3884
|
4574
|
8209
|
8317
|
8322
|
8373
|
9034
|
9035
|
9036
|
34442