Attachment 83441 Details for Bug 22033 – Bug 22033: Remove related_resultset from the list of available methods

[patch] Bug 22033: Remove related_resultset from the list of available methods

Bug-22033-Remove-relatedresultset-from-the-list-of.patch (text/plain), 1.33 KB, created by Martin Renvoize (ashimema) on 2018-12-21 08:33:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-12-21 08:33:13 UTC

Size: 1.33 KB

patch

obsolete

>From b4031a59d5f0fe24825557950de362f440e34f53 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 20 Dec 2018 18:55:34 -0300
>Subject: [PATCH] Bug 22033: Remove related_resultset from the list of
> available methods
>
>It is not covered by tests.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Object.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index e62af3eb11..2dc135e2d1 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -321,7 +321,7 @@ sub unblessed_all_relateds {
> 
>     my %data;
>     my $related_resultsets = $self->_result->{related_resultsets} || {};
>-    my $rs = $self;
>+    my $rs = $self->_result;
>     while ( $related_resultsets and %$related_resultsets ) {
>         my @relations = keys %{ $related_resultsets };
>         if ( @relations ) {
>@@ -404,7 +404,7 @@ sub AUTOLOAD {
>         }
>     }
> 
>-    my @known_methods = qw( is_changed id in_storage get_column discard_changes update related_resultset make_column_dirty );
>+    my @known_methods = qw( is_changed id in_storage get_column discard_changes update make_column_dirty );
> 
>     Koha::Exceptions::Object::MethodNotCoveredByTests->throw(
>         error      => sprintf("The method %s->%s is not covered by tests!", ref($self), $method),
>-- 
>2.19.2

Actions: View | Diff | Splinter Review

Attachments on bug 22033: 83432 | 83441