Bugzilla – Attachment 83443 Details for
Bug 21491
When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
Bug-21491-Display-Yes-as-selected-if-no-refundlost.patch (text/plain), 2.16 KB, created by
Martin Renvoize (ashimema)
on 2018-12-21 11:17:00 UTC
(
hide
)
Description:
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-12-21 11:17:00 UTC
Size:
2.16 KB
patch
obsolete
>From 7e68ae56483f6e38ae8d405eee5cbf29cc7d472b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 21 Nov 2018 13:40:35 +0000 >Subject: [PATCH] Bug 21491: Display 'Yes' as selected if no refundlostitemfee > rules are set > >To test: >1 - Delete all refund_lost_item_fee_rules form the db > delete from refund_lost_item_fee_rules; >2 - View the Standard circ rules - Default lost item fee refund shows as >'No' >3 - View circ rules for a single library, shows as 'Default (Yes)' >4 - Return a lost item, it actually does refund (this is in the > LostItemFeeRules code, default 1 if not set) >5 - Apply patch >6 - Rule shows as 'Yes' >7 - View a specifc rule, still says Default (Yes) > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index f97b2cf42e..f42a63ba80 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -590,14 +590,14 @@ > <select name="refund"> > [#% Default branch %#] > [% IF ( current_branch == '*' ) %] >- [% IF ( refundLostItemFeeRule.refund ) %] >+ [% IF ( ( not refundLostItemFeeRule.refund.defined ) || refundLostItemFeeRule.refund ) %] > <option value="1" selected="selected"> > [% ELSE %] > <option value="1"> > [% END %] > Yes > </option> >- [% IF ( not refundLostItemFeeRule.refund ) %] >+ [% IF ( refundLostItemFeeRule.refund.defined && ( not refundLostItemFeeRule.refund ) ) %] > <option value="0" selected="selected"> > [% ELSE %] > <option value="0"> >-- >2.19.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21491
:
82561
|
82639
|
83443
|
83860