Attachment 83465 Details for Bug 22034 – Bug 22034: Handle default framework for MARC view with framework

[patch] Bug 22034: Handle default framework for MARC view with framework

Bug-22034-Handle-default-framework-for-MARC-view-w.patch (text/plain), 2.27 KB, created by Devinim on 2018-12-21 15:06:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Devinim

Created: 2018-12-21 15:06:44 UTC

Size: 2.27 KB

patch

obsolete

>From 7ac7de7b8ccac1082385d50ea9c35a3d7f97ecbf Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 20 Dec 2018 19:55:46 -0300
>Subject: [PATCH] Bug 22034: Handle default framework for MARC view with
> framework
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To test:
>
>- Create a record in any framework that is not default
>- Search for the record in your catalog
>- Switch to the MARC tab
>- Change framework pull down to default on top
>- Note the page reloads and the framework stay default
>- Verify it works for other frameworks
>
>Also test the "labeled MARC" view (you will need the pref viewLabeledMARC turned on)
>
>Signed-off-by: NazlÄ± Ãetin <nazli@devinim.com.tr>
>---
> catalogue/MARCdetail.pl        | 3 +--
> catalogue/labeledMARCdetail.pl | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl
>index b4adcfdeeae..a22f8eb99e6 100755
>--- a/catalogue/MARCdetail.pl
>+++ b/catalogue/MARCdetail.pl
>@@ -68,8 +68,7 @@ my $query        = new CGI;
> my $dbh          = C4::Context->dbh;
> my $biblionumber = $query->param('biblionumber');
> $biblionumber = HTML::Entities::encode($biblionumber);
>-my $frameworkcode = $query->param('frameworkcode');
>-$frameworkcode = GetFrameworkCode( $biblionumber ) unless ($frameworkcode);
>+my $frameworkcode = $query->param('frameworkcode') // GetFrameworkCode( $biblionumber );
> my $popup        =
>   $query->param('popup')
>   ;    # if set to 1, then don't insert links, it's just to show the biblio
>diff --git a/catalogue/labeledMARCdetail.pl b/catalogue/labeledMARCdetail.pl
>index 9b5105103c3..7c3b77bc9a5 100755
>--- a/catalogue/labeledMARCdetail.pl
>+++ b/catalogue/labeledMARCdetail.pl
>@@ -38,8 +38,7 @@ my $query        = new CGI;
> my $dbh          = C4::Context->dbh;
> my $biblionumber = $query->param('biblionumber');
> $biblionumber = HTML::Entities::encode($biblionumber);
>-my $frameworkcode = $query->param('frameworkcode');
>-$frameworkcode = GetFrameworkCode( $biblionumber ) unless ($frameworkcode);
>+my $frameworkcode = $query->param('frameworkcode') // GetFrameworkCode( $biblionumber );
> my $popup        =
>   $query->param('popup')
>   ;    # if set to 1, then don't insert links, it's just to show the biblio
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22034: 83437 | 83465 | 83560