Bugzilla – Attachment 83476 Details for
Bug 17978
Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17978: Check if hold can be placed before placing on placerequest.pl
Bug-17978-Check-if-hold-can-be-placed-before-placi.patch (text/plain), 2.29 KB, created by
Nick Clemens (kidclamp)
on 2018-12-24 14:52:04 UTC
(
hide
)
Description:
Bug 17978: Check if hold can be placed before placing on placerequest.pl
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-12-24 14:52:04 UTC
Size:
2.29 KB
patch
obsolete
>From 7f393f85e99ce7f7e50a45ff9f89142ce7c5519e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 24 Dec 2018 14:33:51 +0000 >Subject: [PATCH] Bug 17978: Check if hold can be placed before placing on > placerequest.pl > >To test: > 1 - Set an All/All/All rule with reserves limited 2 to > 2 - Search in the staff side > 3 - Select all records (or more than 2) from the results > 4 - Click 'Place hold' > 5 - Find a patron, place holds > 6 - You get more holds than you should > 7 - Delete those holds > 8 - Apply patch > 9 - Search and select more than 2 records >10 - Find patron, place holds >11 - Only 2 holds are placed >--- > reserve/placerequest.pl | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index 351041b5df..1f061fe81a 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -95,14 +95,18 @@ if ( $type eq 'str8' && $borrower ) { > > if ($multi_hold) { > my $bibinfo = $bibinfos{$biblionumber}; >- AddReserve($branch,$borrower->{'borrowernumber'},$biblionumber,[$biblionumber], >- $bibinfo->{rank},$startdate,$expirationdate,$notes,$bibinfo->{title},$checkitem,$found); >+ if ( CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) { >+ AddReserve($branch,$borrower->{'borrowernumber'},$biblionumber,[$biblionumber], >+ $bibinfo->{rank},$startdate,$expirationdate,$notes,$bibinfo->{title},$checkitem,$found); >+ } > } else { > # place a request on 1st available > for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) { >- AddReserve( $branch, $borrower->{'borrowernumber'}, >- $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, >- $checkitem, $found, $itemtype ); >+ if ( CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) { >+ AddReserve( $branch, $borrower->{'borrowernumber'}, >+ $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, >+ $checkitem, $found, $itemtype ); >+ } > } > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17978
:
69927
|
72547
|
73161
|
83476
|
83477
|
86829
|
86830
|
86831
|
87280
|
87281
|
87282