Attachment 83511 Details for Bug 21909 – Bug 21909: Unit tests

[patch] Bug 21909: Unit tests

Bug-21909-Unit-tests.patch (text/plain), 4.12 KB, created by Tomás Cohen Arazi (tcohen) on 2018-12-26 17:51:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-12-26 17:51:02 UTC

Size: 4.12 KB

patch

obsolete

>From c84bc96c1cb5ee7a0591aa09df606885e1f1317c Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 29 Nov 2018 12:08:03 -0300
>Subject: [PATCH] Bug 21909: Unit tests
>
>This patch introduces regression tests for the behaviour to be
>introduced. Both outstanding_credits and outstanding_debits methods
>should return a Koha::Account::Lines object in scalar context, and a
>list of Koha::Account::Line objects in list context.
>
>To test:
>- Apply this patch
>- Run
>  $ kshell
> k$ prove t/db_dependent/Koha/Account.t
>=> FAIL: The current behaviour doesn't match the described
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> t/db_dependent/Koha/Account.t | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Account.t b/t/db_dependent/Koha/Account.t
>index 664a437b69..c828469574 100755
>--- a/t/db_dependent/Koha/Account.t
>+++ b/t/db_dependent/Koha/Account.t
>@@ -33,11 +33,12 @@ my $builder = t::lib::TestBuilder->new;
> 
> subtest 'outstanding_debits() tests' => sub {
> 
>-    plan tests => 13;
>+    plan tests => 22;
> 
>     $schema->storage->txn_begin;
> 
>-    my $patron = $builder->build_object({ class => 'Koha::Patrons' });
>+    my $patron  = $builder->build_object({ class => 'Koha::Patrons' });
>+    my $account = $patron->account;
> 
>     my @generated_lines;
>     push @generated_lines, Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 1 })->store;
>@@ -45,15 +46,18 @@ subtest 'outstanding_debits() tests' => sub {
>     push @generated_lines, Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 3, amountoutstanding => 3 })->store;
>     push @generated_lines, Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 4, amountoutstanding => 4 })->store;
> 
>-    my $account = $patron->account;
>-    my $lines   = $account->outstanding_debits();
>+    my $lines     = $account->outstanding_debits();
>+    my @lines_arr = $account->outstanding_debits();
> 
>+    is( ref($lines), 'Koha::Account::Lines', 'Called in scalar context, outstanding_debits returns a Koha::Account::Lines object' );
>     is( $lines->total_outstanding, 10, 'Outstandig debits total is correctly calculated' );
> 
>     my $i = 0;
>     foreach my $line ( @{ $lines->as_list } ) {
>         my $fetched_line = Koha::Account::Lines->find( $generated_lines[$i]->id );
>         is_deeply( $line->unblessed, $fetched_line->unblessed, "Fetched line matches the generated one ($i)" );
>+        is_deeply( $lines_arr[$i]->unblessed, $fetched_line->unblessed, "Fetched line matches the generated one ($i)" );
>+        is( ref($lines_arr[$i]), 'Koha::Account::Line', 'outstanding_debits returns a list of Koha::Account::Line objects in list context' );
>         $i++;
>     }
> 
>@@ -91,7 +95,7 @@ subtest 'outstanding_debits() tests' => sub {
> 
> subtest 'outstanding_credits() tests' => sub {
> 
>-    plan tests => 8;
>+    plan tests => 17;
> 
>     $schema->storage->txn_begin;
> 
>@@ -104,14 +108,18 @@ subtest 'outstanding_credits() tests' => sub {
>     push @generated_lines, $account->add_credit({ amount => 3 });
>     push @generated_lines, $account->add_credit({ amount => 4 });
> 
>-    my $lines = $account->outstanding_credits();
>+    my $lines     = $account->outstanding_credits();
>+    my @lines_arr = $account->outstanding_credits();
> 
>+    is( ref($lines), 'Koha::Account::Lines', 'Called in scalar context, outstanding_credits returns a Koha::Account::Lines object' );
>     is( $lines->total_outstanding, -10, 'Outstandig credits total is correctly calculated' );
> 
>     my $i = 0;
>     foreach my $line ( @{ $lines->as_list } ) {
>         my $fetched_line = Koha::Account::Lines->find( $generated_lines[$i]->id );
>         is_deeply( $line->unblessed, $fetched_line->unblessed, "Fetched line matches the generated one ($i)" );
>+        is_deeply( $lines_arr[$i]->unblessed, $fetched_line->unblessed, "Fetched line matches the generated one ($i)" );
>+        is( ref($lines_arr[$i]), 'Koha::Account::Line', 'outstanding_debits returns a list of Koha::Account::Line objects in list context' );
>         $i++;
>     }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21909: 82746 | 82747 | 82748 | 82751 | 82752 | 82753 | 82799 | 82800 | 82801 | 83511 | 83512 | 83513