Attachment 83512 Details for Bug 21909 – Bug 21909: Make Koha::Account::outstanding_* preserve context

[patch] Bug 21909: Make Koha::Account::outstanding_* preserve context

Bug-21909-Make-KohaAccountoutstanding-preserve-con.patch (text/plain), 1.71 KB, created by Tomás Cohen Arazi (tcohen) on 2018-12-26 17:51:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-12-26 17:51:07 UTC

Size: 1.71 KB

patch

obsolete

>From ad35ef36451a064b960ed9c5b701a4ba3b28f395 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 29 Nov 2018 12:10:21 -0300
>Subject: [PATCH] Bug 21909: Make Koha::Account::outstanding_* preserve context
>
>This patch modifies the methods so they preserve the caller's context
>(list and scalar).
>
>To test:
>- Apply the first patch
>- Run:
>  $ kshell
> k$ prove t/db_dependent/Koha/Account.t
>=> FAIL: outstanding_credits and outstanding_debits tests fail
>- Apply this patch
>- Run:
> k$ prove t/db_dependent/Koha/Account.t
>=> SUCCESS: We are so happy now :-D
>- Sign off :-D
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> Koha/Account.pm | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/Koha/Account.pm b/Koha/Account.pm
>index 4b68f2aaa9..304d0e2743 100644
>--- a/Koha/Account.pm
>+++ b/Koha/Account.pm
>@@ -428,14 +428,12 @@ my $lines = Koha::Account->new({ patron_id => $patron_id })->outstanding_debits;
> sub outstanding_debits {
>     my ($self) = @_;
> 
>-    my $lines = $self->lines->search(
>+    return $self->lines->search(
>         {
>             amount            => { '>' => 0 },
>             amountoutstanding => { '>' => 0 }
>         }
>     );
>-
>-    return $lines;
> }
> 
> =head3 outstanding_credits
>@@ -447,14 +445,12 @@ my $lines = Koha::Account->new({ patron_id => $patron_id })->outstanding_credits
> sub outstanding_credits {
>     my ($self) = @_;
> 
>-    my $lines = $self->lines->search(
>+    return $self->lines->search(
>         {
>             amount            => { '<' => 0 },
>             amountoutstanding => { '<' => 0 }
>         }
>     );
>-
>-    return $lines;
> }
> 
> =head3 non_issues_charges
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21909: 82746 | 82747 | 82748 | 82751 | 82752 | 82753 | 82799 | 82800 | 82801 | 83511 | 83512 | 83513