Attachment 83514 Details for Bug 21912 – Bug 21912: (QA follow-up) Do not delete existing patrons

[patch] Bug 21912: (QA follow-up) Do not delete existing patrons

Bug-21912-QA-follow-up-Do-not-delete-existing-patr.patch (text/plain), 1.32 KB, created by Tomás Cohen Arazi (tcohen) on 2018-12-26 17:56:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-12-26 17:56:32 UTC

Size: 1.32 KB

patch

obsolete

>From 81d6cbb06d3d1cf38ca21def4c4fc3602d8ae076 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 26 Dec 2018 14:55:53 -0300
>Subject: [PATCH] Bug 21912: (QA follow-up) Do not delete existing patrons
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/Objects.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Objects.t b/t/db_dependent/Koha/Objects.t
>index 5e00ef93e2..db7711e0db 100644
>--- a/t/db_dependent/Koha/Objects.t
>+++ b/t/db_dependent/Koha/Objects.t
>@@ -261,7 +261,7 @@ subtest '->search() tests' => sub {
> 
>     $schema->storage->txn_begin;
> 
>-    Koha::Patrons->delete;
>+    my $count = Koha::Patrons->search->count;
> 
>     # Create 10 patrons
>     foreach (1..10) {
>@@ -271,7 +271,7 @@ subtest '->search() tests' => sub {
>     my $patrons = Koha::Patrons->search();
>     is( ref($patrons), 'Koha::Patrons', 'search in scalar context returns the Koha::Object-based type' );
>     my @patrons = Koha::Patrons->search();
>-    is( scalar @patrons, 10, 'search in list context returns a list of objects' );
>+    is( scalar @patrons, $count + 10, 'search in list context returns a list of objects' );
>     my $i = 0;
>     foreach (1..10) {
>         is( ref($patrons[$i]), 'Koha::Patron', 'Objects in the list have the singular type' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21912: 82745 | 82750 | 83514