Attachment 83577 Details for Bug 22059 – Bug 22059: Fix exception params in Koha::Patron->set_password

[patch] Bug 22059: Fix exception params in Koha::Patron->set_password

Bug-22059-Fix-exception-params-in-KohaPatron-setpa.patch (text/plain), 1.27 KB, created by Kyle M Hall (khall) on 2019-01-02 13:18:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-01-02 13:18:13 UTC

Size: 1.27 KB

patch

obsolete

>From 8baccd970fc50afadd14220bd63408c2d3f772fd Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 2 Jan 2019 09:56:52 -0300
>Subject: [PATCH] Bug 22059: Fix exception params in Koha::Patron->set_password
>
>This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
>enclosed in curly brackets.
>
>To test:
>- Apply the tests patch
>- Run:
>  $ kshell
> k$ prove t/db_dependent/Koha/Patrons.t
>=> FAIL: Tests fail because the throw call is wrong
>- Apply this patch
>- Run:
> k$ prove t/db_dependent/Koha/Patrons.t
>=> SUCCESS: Tests pass!
>-Sign off :-D
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Patron.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 5831034bdc..3a079f60a1 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -703,7 +703,7 @@ sub set_password {
> 
>             my $password_length = length($password);
>             Koha::Exceptions::Password::TooShort->throw(
>-                { length => $password_length, min_length => $min_length } );
>+                length => $password_length, min_length => $min_length );
>         }
>         elsif ( $error eq 'has_whitespaces' ) {
>             Koha::Exceptions::Password::WhitespaceCharacters->throw();
>-- 
>2.17.2 (Apple Git-113)

Actions: View | Diff | Splinter Review

Attachments on bug 22059: 83574 | 83575 | 83576 | 83577 | 83607 | 83608