Attachment 83725 Details for Bug 22051 – Bug 22051: Make Koha::Object->store translate incorrect value exceptions

[patch] Bug 22051: Make Koha::Object->store translate incorrect value exceptions

Bug-22051-Make-KohaObject-store-translate-incorrec.patch (text/plain), 1.67 KB, created by Josef Moravec on 2019-01-08 18:19:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-01-08 18:19:40 UTC

Size: 1.67 KB

patch

obsolete

>From 68a3f5689f4c76fa622f9210adc494d75748bf39 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 28 Dec 2018 12:15:53 -0300
>Subject: [PATCH] Bug 22051: Make Koha::Object->store translate incorrect value
> exceptions
>
>This patch adds a new condition to Koha::Object->store so it catches
>incorrect value-related DBIC exceptions.
>
>This DBIC exceptions get now translated into
>Koha::Exceptions::Object::BadValue exceptions with relevant parameters
>passed.
>
>To test:
>- Apply the exception and unit tests patches
>- Run:
>  $ kshell
> k$ prove t/db_dependent/Koha/Object.t
>=> FAIL: Tests fail because this exception handling code is not
>implemented
>- Apply this patch
>- Run:
> k$ prove t/db_dependent/Koha/Object.t
>=> SUCCESS: Tests pass!
>- Sign off :-D
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> Koha/Object.pm | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index 2dc135e..98867d2 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -143,6 +143,13 @@ sub store {
>                     duplicate_id => $+{key}
>                 );
>             }
>+            elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column '(?<property>\w+)'/ ) {
>+                Koha::Exceptions::Object::BadValue->throw(
>+                    type     => $+{type},
>+                    value    => $+{value},
>+                    property => $+{property}
>+                );
>+            }
>         }
>         # Catch-all for foreign key breakages. It will help find other use cases
>         $_->rethrow();
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22051: 83534 | 83535 | 83536 | 83622 | 83623 | 83624 | 83657 | 83658 | 83659 | 83723 | 83724 | 83725