Attachment 83730 Details for Bug 22049 – Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl

[patch] Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl

Bug-22049-QA-follow-up-update-MarkIssueReturned-ca.patch (text/plain), 1.44 KB, created by Josef Moravec on 2019-01-08 18:48:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-01-08 18:48:03 UTC

Size: 1.44 KB

patch

obsolete

>From 74b775419cab11db465b3513edd7d8912708aa05 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Thu, 3 Jan 2019 10:05:37 +0000
>Subject: [PATCH] Bug 22049: (QA follow-up) update MarkIssueReturned call in
> process_koc.pl
>
>Test plan:
>Try to upload koc file with some returns
>Success: the file should be correctly processed
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> C4/Circulation.pm           | 3 ++-
> offline_circ/process_koc.pl | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 6387d06..cb0f5af 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2101,7 +2101,8 @@ C<$privacy> contains the privacy parameter. If the patron has set privacy to 2,
> the old_issue is immediately anonymised
> 
> Ideally, this function would be internal to C<C4::Circulation>,
>-not exported, but it is currently used in misc/cronjobs/longoverdue.pl.
>+not exported, but it is currently used in misc/cronjobs/longoverdue.pl
>+and offline_circ/process_koc.pl.
> 
> =cut
> 
>diff --git a/offline_circ/process_koc.pl b/offline_circ/process_koc.pl
>index a72dbdd..174f00d 100755
>--- a/offline_circ/process_koc.pl
>+++ b/offline_circ/process_koc.pl
>@@ -335,7 +335,6 @@ sub kocReturnItem {
>         C4::Circulation::MarkIssueReturned(
>             $borrowernumber,
>             $item->itemnumber,
>-            undef,
>             $circ->{'date'},
>             $patron->privacy
>         );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22049: 83542 | 83543 | 83544 | 83548 | 83549 | 83625 | 83626 | 83627 | 83654 | 83655 | 83656 | 83727 | 83728 | 83729 | 83730 | 85498