Attachment 83774 Details for Bug 22097 – Bug 22097: CataloguingLog should be suppressed for item branch transfers

[patch] Bug 22097: CataloguingLog should be suppressed for item branch transfers

Bug-22097-CataloguingLog-should-be-suppressed-for-.patch (text/plain), 1.24 KB, created by Owen Leonard on 2019-01-10 19:57:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-01-10 19:57:06 UTC

Size: 1.24 KB

patch

obsolete

>From 75e829340d79ae0261a8f263a38b5f84efd034d1 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 10 Jan 2019 14:32:22 -0500
>Subject: [PATCH] Bug 22097: CataloguingLog should be suppressed for item
> branch transfers
>
>Bug 18816 missed the fact that a branch transfer triggers ModItem and
>thus generates an action log line. We should not be creating those
>action logs, especially considering the transfers table itself already
>documents the transfer.
>
>Test Plan:
>1) Enable CataloguingLog
>2) Transfer an item to another branch
>3) Note the new action log line created
>4) Apply this patch
>5) Create another item transfer
>6) No new action log line should be created!
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> C4/Items.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 3b006c6..4d884ff 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -624,7 +624,7 @@ sub ModItemTransfer {
>         VALUES (?, ?, NOW(), ?)");
>     $sth->execute($itemnumber, $frombranch, $tobranch);
> 
>-    ModItem({ holdingbranch => $tobranch }, undef, $itemnumber);
>+    ModItem({ holdingbranch => $tobranch }, undef, $itemnumber, { log_action => 0 });
>     ModDateLastSeen($itemnumber);
>     return;
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22097: 83773 | 83774 | 84678