Attachment 83837 Details for Bug 22111 – Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff)

[patch] Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff)

Bug-22111-Format-amount-shown-on-place-holds-when-.patch (text/plain), 1.96 KB, created by Katrin Fischer on 2019-01-12 08:17:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-01-12 08:17:59 UTC

Size: 1.96 KB

patch

obsolete

>From dc80f9dfccae6660d7f4d7988bcccd2813ac3a35 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 5 Jan 2019 03:50:36 +0000
>Subject: [PATCH] Bug 22111: Format amount shown on place holds when
> maxoutstanding is reached (staff)
>
>Displays amount outstanding correctly when holds are blocked
>by maxoutstanding.
>
>To test:
>- Check maxoutstanding system preference value
>- Add a fine to a patron account exceeding maxoutstanding
>- Try to place a hold for this patron from staff
>- Verify this message is shown:
>
>     Patron has outstanding fines: 6.00
>
>- Toggle CurrencyFormat system preference and verify display
>  changes according to setting
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 9ed0bd84a5..3983ca529f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -6,6 +6,7 @@
> [% USE Categories %]
> [% USE ItemTypes %]
> [% USE AuthorisedValues %]
>+[% USE Price %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> [% UNLESS ( multi_hold ) %]
>@@ -139,7 +140,7 @@
>     [% END %]
> 
>     [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %]
>-    <li><a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber | uri %]">[% patron.firstname | html %] [% patron.surname | html %]</a>: <strong>Patron has outstanding fines: [% amount_outstanding | format('%.2f') %]</strong></li>
>+    <li><a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber | uri %]">[% patron.firstname | html %] [% patron.surname | html %]</a>: <strong>Patron has outstanding fines: [% amount_outstanding | $Price ) %]</strong></li>
>     [% END %]
> 
>     [% IF ( diffbranch ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22111: 83832 | 83837 | 83987 | 84228 | 84269