Attachment 83884 Details for Bug 22124 – Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag

[patch] Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag

Bug-22124-Update-cataloguing-plugin-system-to-not-.patch (text/plain), 1.14 KB, created by Josef Moravec on 2019-01-14 11:28:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-01-14 11:28:43 UTC

Size: 1.14 KB

patch

obsolete

>From 06f994f87cc36d5bb4b0a08dda466e4a0e49294e Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 14 Jan 2019 09:16:53 +0000
>Subject: [PATCH] Bug 22124: Update cataloguing plugin system to not generate
> type parameter in script tag
>
>Test plan:
>1) Apply the patch
>2) Have defined some cataloguing plugin which generates javascript - for
>example dateaccessioned.pl
>3) Go to cataloguing/adding item and show source
>-> there should be no type parameter in script tag in code added by
>cataloguing pulgin
>4) prove t/db_dependent/FrameworkPlugin.t
>---
> Koha/FrameworkPlugin.pm | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/Koha/FrameworkPlugin.pm b/Koha/FrameworkPlugin.pm
>index 2d7390fd95..418c0a3ab3 100644
>--- a/Koha/FrameworkPlugin.pm
>+++ b/Koha/FrameworkPlugin.pm
>@@ -376,8 +376,7 @@ sub _merge_script {
>     my ( $id, $script, $bind ) = @_;
>     chomp ($script, $bind);
>     return <<HERE;
>-<script type="text/javascript">
>-//<![CDATA[
>+<script>
> $script
> function BindEvents$id() {
> $bind
>@@ -385,7 +384,6 @@ $bind
> \$(document).ready(function() {
>     BindEvents$id();
> });
>-//]]>
> </script>
> HERE
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22124: 83884 | 83886 | 84243