Attachment 84001 Details for Bug 22006 – Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item

[patch] Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item

Bug-22006-Handle-undefined-itemnumber-for-KohaAcco.patch (text/plain), 1.21 KB, created by Tomás Cohen Arazi (tcohen) on 2019-01-15 18:43:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-01-15 18:43:55 UTC

Size: 1.21 KB

patch

obsolete

>From 540a3d67670665a982ce7ebd7118401eea72c7bb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 14 Dec 2018 16:15:24 -0300
>Subject: [PATCH] Bug 22006: Handle undefined itemnumber for
> Koha::Account::Line->item
>
>If there is no item linked to an account line, the ->item method should return undef.
>Without this patch it explodes with:
>Carp::croak('DBIC result _type  isn\'t of the _type Item') called at /home/vagrant/kohaclone/Koha/Object.pm line 102
>
>Exists since the introduction of this method by bug 12001
>
>Reported on bug 19489 comment 18.
>
>Test plan:
>  prove t/db_dependent/Koha/Account/Lines.t
>must return green
>
>Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Account/Line.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
>index 529b625d02..df5d98b016 100644
>--- a/Koha/Account/Line.pm
>+++ b/Koha/Account/Line.pm
>@@ -50,6 +50,7 @@ Return the item linked to this account line if exists
> sub item {
>     my ( $self ) = @_;
>     my $rs = $self->_result->itemnumber;
>+    return unless $rs;
>     return Koha::Item->_new_from_dbic( $rs );
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22006: 83240 | 83241 | 83246 | 83247 | 84000 | 84001