Bugzilla – Attachment 84010 Details for
Bug 21206
C4::Items - Remove GetItem
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem
Bug-21206-QA-follow-up-Rebase-problem-and-leftover.patch (text/plain), 3.11 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-01-15 19:37:56 UTC
(
hide
)
Description:
Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-01-15 19:37:56 UTC
Size:
3.11 KB
patch
obsolete
>From e4b844d9b15de90960b48d8f4be78065cd4e4a66 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 15 Jan 2019 16:32:57 -0300 >Subject: [PATCH] Bug 21206: (QA follow-up) Rebase problem and leftover mocked > GetItem > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Circulation.pm | 2 +- > t/db_dependent/Circulation.t | 10 ++++------ > 2 files changed, 5 insertions(+), 7 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 5ab337af82..5853ec15ea 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2907,7 +2907,7 @@ sub AddRenewal { > branchcode => $branchcode, > description => 'Renewal of Rental Item ' > . $biblio->title >- . " $item->barcode", >+ . " " . $item->barcode, > } > )->store(); > } >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 07d15412ca..fd099daccf 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2531,16 +2531,16 @@ subtest 'Cancel transfers on lost items' => sub { > #Check transfer exists and the items holding branch is the transfer destination branch before marking it as lost > my ($datesent,$frombranch,$tobranch) = GetTransfers($item->{itemnumber}); > is( $tobranch, $library_2->{branchcode}, 'The transfer record exists in the branchtransfers table'); >- my $itemcheck = GetItem($item->{itemnumber}); >- is( $itemcheck->{holdingbranch}, $library_2->{branchcode}, 'Items holding branch is the transfers destination branch before it is marked as lost' ); >+ my $itemcheck = Koha::Items->find($item->{itemnumber}); >+ is( $itemcheck->holdingbranch, $library_2->{branchcode}, 'Items holding branch is the transfers destination branch before it is marked as lost' ); > > #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch > ModItem( { itemlost => 1 }, $biblio->{biblionumber}, $item->{itemnumber} ); > LostItem( $item->{itemnumber}, 'test', 1 ); > ($datesent,$frombranch,$tobranch) = GetTransfers($item->{itemnumber}); > is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled'); >- $itemcheck = GetItem($item->{itemnumber}); >- is( $itemcheck->{holdingbranch}, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' ); >+ $itemcheck = Koha::Items->find($item->{itemnumber}); >+ is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' ); > }; > > subtest 'CanBookBeIssued | is_overdue' => sub { >@@ -2924,8 +2924,6 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub { > ); > my $item = Koha::Items->find( $item_id ); > >- my $items = Test::MockModule->new('C4::Items'); >- $items->mock( GetItem => $item->unblessed ); > my $context = Test::MockModule->new('C4::Context'); > $context->mock( userenv => { branch => $library->id } ); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21206
:
77699
|
77700
|
77701
|
78080
|
78081
|
78082
|
78153
|
78154
|
78155
|
82831
|
82832
|
82833
|
82834
|
84006
|
84007
|
84008
|
84009
|
84010
|
84184
|
84185
|
84186
|
84187
|
84188
|
85163
|
85164
|
85165
|
85166
|
85167
|
85168