Attachment 84130 Details for Bug 20527 – Bug 20527: Significant inputs will be focused on in the "Accounting" section of a patron.

[patch] Bug 20527: Significant inputs will be focused on in the "Accounting" section of a patron.

Bug-20527-Significant-inputs-will-be-focused-on-in.patch (text/plain), 6.26 KB, created by ByWater Sandboxes on 2019-01-17 08:04:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2019-01-17 08:04:30 UTC

Size: 6.26 KB

patch

obsolete

>From 0255951012c68b7474b6f15eafd4e01d9889a3c0 Mon Sep 17 00:00:00 2001
>From: Ethan Amohia <ethan.amohia@gmail.com>
>Date: Wed, 16 Jan 2019 21:40:13 +0000
>Subject: [PATCH] Bug 20527: Significant inputs will be focused on in the
> "Accounting" section of a patron.
>
>Test Plan:
>1. From the homepage, select Patrons.
>2. Search for any patron and select any patron.
>3. You should be seeing the patrons' details. On the left, select "Accounting".
>4. Click on "Pay".
>5. The "Collect from patron" field should be focused. This means you
>should not have to click on the input field to start typing, it should
>already be selected. Confirm that this
>works.
>6. Click "Cancel" and you should be back to the "Make a payment" tab.
>7. Click on "Write off".
>8.The "Writeoff amount" field should be focused. Confirm that this
>works.
>9. Click "Cancel" and you should be back to the "Make a payment" tab.
>10. Click on "Pay amount".
>11. The "Collect from patron" field should be focused. Confirm that this
>works.
>12. Click "Pay fines" tab and you should be back to the "Make a payment" tab.
>13. Click on "Pay selected".
>14. Repeat steps 12 & 13.
>15. Click  on "Write off selected".
>16. The "Writeoff amount" field should be focused. Confirm that this
>works.
>17. Click "Pay fines" tab and you should be back to the "Make a payment" tab.
>18. Click the "Create manual invoice".
>19. The "Amount" field should be focused. Confirm that this works.
>20. Click on "Create manual credit".
>21. The "Amount" field should be focused. Confirm that this works.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt  | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt        | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>index 5a74f115a9..3539d0c151 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>@@ -44,7 +44,7 @@
> 	<li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li>
> 	<li><label for="desc">Description: </label><input type="text" name="desc" size="50" id="desc" /></li>
>     <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
>-    <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li>
>+    <li><label for="amount">Amount: </label><input type="number" class="focus" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li>
> </ol></fieldset>
> 
> <fieldset class="action"><input type="submit" name="add" value="Add credit" /> <a class="cancel" href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% patron.borrowernumber | html %]">Cancel</a></fieldset>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>index 4d1a92f8a2..119c17d8c0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>@@ -57,7 +57,7 @@
> 	<li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li>
> 	<li><label for="desc">Description: </label><input type="text" name="desc" id="desc" size="50" /></li>
>     <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
>-    <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li>
>+    <li><label for="amount">Amount: </label><input type="number" class="focus" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li>
> 	</ol></fieldset>
> <fieldset class="action"><input type="submit" name="add" value="Save" /> <a class="cancel" href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% patron.borrowernumber | html %]">Cancel</a></fieldset>
> </form>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>index b58c4e66e3..33c8fbfec7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>@@ -107,7 +107,7 @@
>         [%- IF line.description %], [% line.description | html %][% END %]
>         [% IF line.title %]([% line.title | html %])[% END %]
>     </td>
>-    <td><input type="text" name="payment_note_[% line.accountlines_id | html %]" /></td>
>+    <td><input type="text" class="focus" name="payment_note_[% line.accountlines_id | html %]" /></td>
>     <td>[% line.accounttype | html %]</td>
>     <td class="debit" style="text-align: right;">[% line.amount | $Price %]</td>
>     <td class="debit" style="text-align: right;">[% line.amountoutstanding | $Price %]</td>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>index e0af674642..fbbdc3a724 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>@@ -101,7 +101,7 @@
>     <li>
>         <label for="paid">Collect from patron: </label>
>             
>-        <input name="paid" id="paid" value="[% amountoutstanding | html %]"  type="text" />
>+        <input name="paid" id="paid" class="focus" value="[% amountoutstanding | html %]"  type="text" />
>     </li>
>     [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
>     [% IF payment_types %]
>@@ -198,7 +198,7 @@
>             <label for="paid">Collect from patron: </label>
>         [% END %]
>         
>-        <input name="paid" id="paid" value="[% total | format('%.2f') %]" type="text" />
>+        <input name="paid" class="focus" id="paid" value="[% total | format('%.2f') %]" type="text" />
>     </li>
>     [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
>     [% IF payment_types %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20527: 84034 | 84100 | 84110 | 84130 | 84131 | 115494 | 115536 | 115568 | 115570