Bugzilla – Attachment 84144 Details for
Bug 20274
itemtypes.plugin report: not handling item-level_itypes syspref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20274: Itemtypes report gives zero results if item-level_itypes set to bibliographic records
Bug-20274-Itemtypes-report-gives-zero-results-if-i.patch (text/plain), 1.63 KB, created by
Tomás Cohen Arazi
on 2019-01-17 15:50:33 UTC
(
hide
)
Description:
Bug 20274: Itemtypes report gives zero results if item-level_itypes set to bibliographic records
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2019-01-17 15:50:33 UTC
Size:
1.63 KB
patch
obsolete
>From 4d39abedbfbabbcb0150bc1d8abb5cb1f4c79524 Mon Sep 17 00:00:00 2001 >From: helene hickey <hickeyhe@wgc.school.nz> >Date: Tue, 15 Jan 2019 23:07:34 +0000 >Subject: [PATCH] Bug 20274: Itemtypes report gives zero results if > item-level_itypes set to bibliographic records > >1) Go to reports then catalog by item types >2) Pick a location and look at table >3) Change the system prefernce of item-level_itypes >4) Verify a zero result >5) Apply patch and retry >6) Verify that result does not change to zero on either preference > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > reports/itemtypes.plugin | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/reports/itemtypes.plugin b/reports/itemtypes.plugin >index ffa6fb7a43..6884369ce2 100755 >--- a/reports/itemtypes.plugin >+++ b/reports/itemtypes.plugin >@@ -53,7 +53,7 @@ sub calculate { > } > else { > $sth = $dbh->prepare(" >- SELECT itemtype, description, biblioitems.itemtype, COUNT(*) AS total >+ SELECT biblioitems.itemtype, description, biblioitems.itemtype, COUNT(*) AS total > FROM itemtypes, biblioitems, items > WHERE biblioitems.itemtype=itemtypes.itemtype > AND items.biblioitemnumber=biblioitems.biblioitemnumber >@@ -65,7 +65,7 @@ sub calculate { > } else { > if (C4::Context->preference('item-level_itypes')) { > $sth = $dbh->prepare(" >- SELECT itemtype, description,items.itype AS itemtype, COUNT(*) AS total >+ SELECT biblioitems.itemtype, description,items.itype AS itemtype, COUNT(*) AS total > FROM itemtypes,items > WHERE items.itype=itemtypes.itemtype > GROUP BY items.itype >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20274
:
84032
|
84138
| 84144