Bugzilla – Attachment 84190 Details for
Bug 21170
Warnings in MARCdetail.pl - isn't numeric in numeric eq (==)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail
Bug-21170-Remove-isnt-numeric-in-numeric-eq--warni.patch (text/plain), 1.55 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-01-18 13:08:37 UTC
(
hide
)
Description:
Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-01-18 13:08:37 UTC
Size:
1.55 KB
patch
obsolete
>From 5571915ba3046acb2cd40a8c89a875792d1639b5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 17 Dec 2018 12:55:34 -0300 >Subject: [PATCH] Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings > in MARCdetail > >Easily removed switching the two conditions. > >Test plan: >Hit catalogue/MARCdetail.pl?biblionumber=1 >=> Without this patch you will see in the log warnings like > Argument "ddc" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277. >=> With this patch applied the warnings do no longer appear > >Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > catalogue/MARCdetail.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl >index a22f8eb99e..7e67b564e1 100755 >--- a/catalogue/MARCdetail.pl >+++ b/catalogue/MARCdetail.pl >@@ -273,7 +273,9 @@ foreach my $field (@fields) { > $tagslib->{ $field->tag() }->{ $subf[$i][0] }->{lib}; > $item->{ $subf[$i][0] } = GetAuthorisedValueDesc( $field->tag(), > $subf[$i][0], $subf[$i][1], '', $tagslib) || $subf[$i][1]; >- $norequests = 0 if $subf[$i][1] ==0 and $tagslib->{ $field->tag() }->{ $subf[$i][0] }->{kohafield} eq 'items.notforloan'; >+ $norequests = 0 >+ if $tagslib->{ $field->tag() }->{ $subf[$i][0] }->{kohafield} eq 'items.notforloan' >+ and $subf[$i][1] == 0; > } > push @item_loop, $item if $item; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21170
:
83303
|
83471
| 84190