Attachment 84219 Details for Bug 7960 – Bug 7960: Add class to item type descriptions so they can be hidden with CSS

[patch] Bug 7960: Add class to item type descriptions so they can be hidden with CSS

Bug-7960-Add-class-to-item-type-descriptions-so-th.patch (text/plain), 18.79 KB, created by Charles Farmer on 2019-01-18 20:51:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Charles Farmer

Created: 2019-01-18 20:51:02 UTC

Size: 18.79 KB

patch

obsolete

>From bcfc56438f900bbcc3b85e3eed36ec2f5e417bfb Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Sun, 1 Jul 2018 23:33:07 +0000
>Subject: [PATCH] Bug 7960: Add class to item type descriptions so they can be
> hidden with CSS
>
>This patch adds the class "itypetext" around item type descriptions so
>they can easily be hidden with CSS.
>
>To test:
>1. Navigate to the pages listed below to confirm that the text
>descriptions do show.
>2. Add
>.itypetext { display:none; }
>to IntranetUserCSS and OPACUserCSS system preferences and save.
>3. Go back to the pages listed below and confirm that the text
>descriptions DO NOT show.
>
>= STAFF CLIENT =
> - catalogue/advsearch.tt
> - catalogue/detail.tt
> - catalogue/results.tt
> - reserve/request.tt
> - virtualshelves/shelves.tt
>= OPAC =
> - opac-advsearch.tt
> - opac-detail.tt
> - opac-readingrecord.tt
> - opac-reserve.tt
> - opac-results-grouped.tt
> - opac-shelves.tt
> - opac-user.tt
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
>---
> .../intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 12 ++++++++++--
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> .../opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++--
> .../opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +-
> 12 files changed, 25 insertions(+), 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>index e6a143f..3eac9a6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>@@ -121,7 +121,7 @@
> <tr>
> [% FOREACH itemtypeloo IN advsearchloo.code_loop %]
> <td><input type="checkbox" id="[% itemtypeloo.ccl FILTER remove(',') | html %]-[% itemtypeloo.number | html %]" name="limit" value="mc-[% itemtypeloo.ccl | html %]:[% itemtypeloo.code | html %]"/><label for="[% itemtypeloo.ccl FILTER remove(',') | html %]-[% itemtypeloo.number | html %]">[% UNLESS ( noItemTypeImages ) %][% IF ( itemtypeloo.imageurl ) %]<img src="[% itemtypeloo.imageurl | html %]" alt="[% itemtypeloo.description | html %]" />[% END %]&nbsp;[% END %]
>- [% itemtypeloo.description | html %]</label></td>
>+ [% itemtypeloo.description | html %]</label></td>
> [% IF ( loop.last ) %]</tr>[% ELSE %][% UNLESS ( loop.count % 5 ) %]</tr><tr>[% END %][% END %]
> [% END %]
> </table>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index bfab772..d51c1a0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -414,6 +414,7 @@
> ([% item.publisheddate | $KohaDates %])
> [% END %]
> [% END %]
>+ [% item.translated_description | html %]
> </td>
> [% END %]
> <td class="status">
>@@ -793,7 +794,7 @@
> <div id="editions"><h4>Editions</h4>
> <table>
> [% FOREACH XISBN IN XISBNS %]<tr>[% IF ( AmazonCoverImages ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link"><img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn | html %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %]
>-[% UNLESS ( item_level_itypes ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description | html %][% ELSE %]<img src="[% XISBN.imageurl | html %]" alt="[% XISBN.description | html %]" title="[% XISBN.description | html %]">[% END %]</td>[% END %]
>+[% UNLESS ( item_level_itypes ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description | html %][% ELSE %]<img src="[% XISBN.imageurl | html %]" alt="[% XISBN.description | html %]" title="[% XISBN.description | html %]">[% END %]</td>[% END %]
> <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% XISBN.biblionumber | uri %]">[% XISBN.title | html %]</a> by [% XISBN.author | html %] &copy;[% XISBN.copyrightdate | html %]
> [% IF ( XISBN.publishercode ) %]
> [% XISBN.publishercode | html %] [% IF ( XISBN.place ) %]([% XISBN.place | html %])[% END %] [% IF ( XISBN.publicationyear ) %], [% XISBN.publicationyear | html %][% END %] [% IF ( XISBN.editionstatement ) %][% XISBN.editionstatement | html %][% END %] [% IF ( XISBN.editionresponsibility ) %][% XISBN.editionresponsibility | html %][% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index e264573..8cf0f1f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -396,7 +396,7 @@
> [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %]
> <img src="[% SEARCH_RESULT.imageurl | html %]" alt="[% SEARCH_RESULT.description | html %]" />
> [% END %]
>- [% SEARCH_RESULT.description | html %]
>+ [% SEARCH_RESULT.description | html %]
> </div>
> [% END %]
> 
>@@ -512,7 +512,7 @@
> [% IF ( available_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&amp;q=%22[% available_items_loo.itemcallnumber |uri %]%22">[% available_items_loo.itemcallnumber | html %]</a>][% END %]
> ([% available_items_loo.count | html %])
> [% IF item_level_itypes && available_items_loo.description %]
>- [% available_items_loo.description | html %]
>+ [% available_items_loo.description | html %]
> [% END %]
> </li>
> [% END %]
>@@ -534,7 +534,11 @@
> [% IF ( onloan_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&amp;q=%22[% onloan_items_loo.itemcallnumber |uri %]%22">[% onloan_items_loo.itemcallnumber | html %]</a>][% END %]
> ([% onloan_items_loo.count | html %][% IF ( onloan_items_loo.longoverdue ) %], [% onloan_items_loo.longoverdue | html %] long overdue[% END %]) date due: [% onloan_items_loo.due_date | $KohaDates %]
> [% IF item_level_itypes && onloan_items_loo.description %]
>+<<<<<<< HEAD
> [% onloan_items_loo.description | html %]
>+=======
>+ [% onloan_items_loo.description %]
>+>>>>>>> Bug 7960: Add class to item type descriptions so they can be hidden with CSS
> [% END %]
> </li>
> [% END %]
>@@ -562,7 +566,11 @@
> [% IF ( other_items_loo.notforloan ) %][% other_items_loo.notforloan | html %][% END %]
> ([% other_items_loo.count | html %])
> [% IF item_level_itypes && other_items_loo.description %]
>+<<<<<<< HEAD
> [% other_items_loo.description | html %]
>+=======
>+ [% other_items_loo.description %]
>+>>>>>>> Bug 7960: Add class to item type descriptions so they can be hidden with CSS
> [% END %]
> </li>
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 9ed0bd8..a452c62 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -352,7 +352,7 @@
> [% UNLESS ( noItemTypeImages ) %]
> [% IF ( itemloo.imageurl ) %]<img src="[% itemloo.imageurl | html %]" alt="" /> [% END %]
> [% END %]
>- [% itemloo.itypename | html %]
>+ [% itemloo.itypename | html %]
> </td>
> [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index 84bfc52..c3df76b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -212,7 +212,7 @@
> </td>
> [% END %]
> 			[% UNLESS ( item_level_itypes ) %]<td>
>- [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />[% END %][% itemsloo.description | html %]
>+ [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />[% END %][% itemsloo.description | html %]
> 			</td>[% END %]
> 			<td>
> [% IF ( itemsloo.XSLTBloc ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>index 1d7aada..5ed5562 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>@@ -151,7 +151,7 @@
> [% END %]
> &nbsp;
> [% END %]
>- [% itemtypeloo.description | html %]
>+ [% itemtypeloo.description | html %]
> </label>
> </div>
> [% IF ( loop.last ) %]</div>[% ELSE %][% UNLESS ( loop.count % 4 ) %]</div><div class="row-fluid">[% END %][% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 955a2f4..9da7c2f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -327,7 +327,7 @@
> [% IF ( imgeurl ) %]
> <img src="[% imageurl | html %]" alt="" />
> [% END %]
>- Item type: 
>+ Item type: 
> [% IF ( description ) %]
> [% description | html %]
> [% ELSE %]
>@@ -1230,7 +1230,7 @@
> <img src="[% ITEM_RESULT.imageurl | html %]" title="[% ITEM_RESULT.description | html %]" alt="[% ITEM_RESULT.description | html %]" />
> [% END %]
> [% END %]
>- [% ITEM_RESULT.description | html %]
>+ [% ITEM_RESULT.description | html %]
> </td>
> [% END %]
> [% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>index d03d5185..65ccbf4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>@@ -151,8 +151,8 @@
> <img src="[% issue.imageurl | html %]" alt="" />
> [% END %]
> [% END %]
>- Item type:
>- [% issue.translated_description | html %]</td>
>+ Item type:
>+ [% issue.translated_description | html %]</td>
> <td>
> Call number:
> [% issue.itemcallnumber | html %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index d4c4d68..81da70e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -201,7 +201,7 @@
> <li class="itype">
> Item type: 
> [% IF ( bibitemloo.imageurl ) %]<img src="[% bibitemloo.imageurl | html %]" alt="" />[% END %]
>- [% bibitemloo.translated_description | html %]
>+ [% bibitemloo.translated_description | html %]
> </li>
> [% END %]
> 
>@@ -368,7 +368,7 @@
> <img src="[% itemLoo.imageurl | html %]" alt="" />
> [% END %]
> [% END %]
>- [% itemLoo.translated_description | html %]
>+ [% itemLoo.translated_description | html %]
> </td>
> [% END %]
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
>index a5ee7ff..b6c80cc 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
>@@ -171,7 +171,7 @@
> <img src="[% GROUP_RESULT.imageurl | html %]" title="[% GROUP_RESULT.description | html %]" />
> [% END %]
> [% END %]
>- [% GROUP_RESULT.description | html %]
>+ [% GROUP_RESULT.description | html %]
> [% END %]
> </td>
> <td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 581adfd..81d2b2d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -299,7 +299,7 @@
> [% UNLESS ( noItemTypeImages ) %]
> <img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />
> [% END %]
>- [% itemsloo.description | html %]
>+ [% itemsloo.description | html %]
> </td>
> [% END %]
> <td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 7af3a0f..8468c94 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -274,7 +274,7 @@
> Item type:
> [% IF ( ISSUE.imageurl ) %]
> <img src="[% ISSUE.imageurl | html %]" title="[% ISSUE.description | html %]" alt="[% ISSUE.description | html %]" />
>- [% END %] [% ISSUE.description | html %]
>+ [% END %] [% ISSUE.description | html %]
> </td>
> [% END %]
> [% IF ( show_barcode ) %]
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 7960: 9189 | 62344 | 62807 | 62932 | 62933 | 76608 | 83853 | 84219 | 98778 | 137760 | 140217 | 140237 | 141284 | 141286