Bugzilla – Attachment 84227 Details for
Bug 22102
Markup fixes for OPAC article request page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22102: Markup fixes for OPAC article request page
Bug-22102-Markup-fixes-for-OPAC-article-request-pa.patch (text/plain), 2.51 KB, created by
Maryse Simard
on 2019-01-18 21:43:39 UTC
(
hide
)
Description:
Bug 22102: Markup fixes for OPAC article request page
Filename:
MIME Type:
Creator:
Maryse Simard
Created:
2019-01-18 21:43:39 UTC
Size:
2.51 KB
patch
obsolete
>From f7a35e980e4da83991caa8e3fa895e12121957cf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 11 Jan 2019 14:52:28 +0000 >Subject: [PATCH] Bug 22102: Markup fixes for OPAC article request page > >This patch makes a few improvements to the OPAC article request page: > >- Improve the breadcrumbs menu by adding a link to the title >- Add a header with the record's title >- Wrap the "no article requests" message in the correct dialog div >- Remove obsolete CDATA marker > >To test, apply the patch and log in to the OPAC > > - Peform a search which will return multiple results > - Click "Request article" on a title for which article requests can be > submitted. > - Confirm that the breadcrumbs menu looks and works correctly. > - Click "Request article" on a title for which article requsts are not > allowed. > - Confirm that the message is correctly styled. > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >index 69e4527..25af23e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >@@ -13,6 +13,7 @@ > <div class="main"> > <ul class="breadcrumb"> > <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> >+ <li><a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | uri %]">Details for: [% biblio.title | html %]</a> <span class="divider">›</span></li> > <li><a href="#">Request article</a></li> > </ul> > >@@ -177,7 +178,10 @@ > <input type="submit" class="btn" value="Place request" /> > </form> > [% ELSE %] >- No article requests can be made for this record. >+ <h1 class="title">[% biblio.title | html %]</h1> >+ <div class="alert alert-info"> >+ No article requests can be made for this record. >+ </div> > [% END %] > > </div> <!-- / .container --> >@@ -187,7 +191,6 @@ > > [% BLOCK jsinclude %] > <script> >-// <![CDATA[ > allow_submit = false; > $('#place-article-request').on('submit', function( event ){ > if ( ! allow_submit ) { >@@ -220,6 +223,5 @@ > $('#place-article-request').submit(); > } > }); >-// ]]> > </script> > [% END %] >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22102
:
83802
|
83888
|
84227
|
84236