Attachment 84238 Details for Bug 22134 – k

[patch] k

Bug-20274-Itemtypes-report-gives-zero-results-if-i.patch (text/plain), 1.74 KB, created by Katrin Fischer on 2019-01-20 11:31:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-01-20 11:31:10 UTC

Size: 1.74 KB

patch

obsolete

>From 86a900b0822cd1e4d22cdfa202f42737e60ce95e Mon Sep 17 00:00:00 2001
>From: helene hickey <hickeyhe@wgc.school.nz>
>Date: Tue, 15 Jan 2019 23:07:34 +0000
>Subject: [PATCH] Bug 20274: Itemtypes report gives zero results if
> item-level_itypes set to bibliographic records
>
>1) Go to reports then catalog by item types
>2) Pick a location and look at table
>3) Change the system prefernce of item-level_itypes
>4) Verify a zero result
>5) Apply patch and retry
>6) Verify that result does not change to zero on either preference
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=22134
>---
> reports/itemtypes.plugin | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/reports/itemtypes.plugin b/reports/itemtypes.plugin
>index ffa6fb7a43..6884369ce2 100755
>--- a/reports/itemtypes.plugin
>+++ b/reports/itemtypes.plugin
>@@ -53,7 +53,7 @@ sub calculate {
> 		}
> 		else {
> 		$sth = $dbh->prepare("
>-        SELECT itemtype, description, biblioitems.itemtype, COUNT(*) AS total
>+        SELECT biblioitems.itemtype, description, biblioitems.itemtype, COUNT(*) AS total
> 			FROM itemtypes, biblioitems, items 
> 		WHERE biblioitems.itemtype=itemtypes.itemtype 
> 		AND items.biblioitemnumber=biblioitems.biblioitemnumber
>@@ -65,7 +65,7 @@ sub calculate {
> 	} else {
> 		if (C4::Context->preference('item-level_itypes')) {
> 		$sth = $dbh->prepare("
>-        SELECT itemtype, description,items.itype AS itemtype, COUNT(*) AS total
>+        SELECT biblioitems.itemtype, description,items.itype AS itemtype, COUNT(*) AS total
> 			FROM itemtypes,items
> 		WHERE items.itype=itemtypes.itemtype
> 			GROUP BY items.itype
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22134: 83972 | 83998 | 84147 | 84162 | 84191 | 84214 | 84215 | 84238 | 84240 | 84241