Bugzilla – Attachment 84282 Details for
Bug 21495
Regression in hold override functionality
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21495: Regression in hold override functionality
Bug-21495-Regression-in-hold-override-functionalit.patch (text/plain), 2.15 KB, created by
Kyle M Hall (khall)
on 2019-01-22 14:09:56 UTC
(
hide
)
Description:
Bug 21495: Regression in hold override functionality
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-01-22 14:09:56 UTC
Size:
2.15 KB
patch
obsolete
>From 6ff48b5f0650e6be6bfcfe60069d369ec00b40fc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 15 Nov 2018 08:35:33 -0500 >Subject: [PATCH] Bug 21495: Regression in hold override functionality > >The changes caused by the patches for bug 11512 have broken existing >workflows for many libraries and are widely considered to be a bad move. >We should revert this behavior. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> >--- > .../prog/en/modules/admin/preferences/circulation.pref | 2 +- > reserve/request.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 322badd6fc..568fce679e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -582,7 +582,7 @@ Circulation: > choices: > yes: Allow > no: "Don't allow" >- - staff to force addition of holds even if the patron already has the maximum number of holds allowed. >+ - staff to override hold policies when placing holds. > - > - pref: AllowHoldsOnDamagedItems > choices: >diff --git a/reserve/request.pl b/reserve/request.pl >index 2534fe2580..91b6ffdd95 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -490,7 +490,7 @@ foreach my $biblionumber (@biblionumbers) { > > push( @available_itemtypes, $item->{itype} ); > } >- elsif ( $can_item_be_reserved->{status} eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) { >+ elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { > # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules > $item->{override} = 1; > $num_override++; >-- >2.17.2 (Apple Git-113)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21495
:
82359
|
82361
|
82416
|
84282
|
84485