Bugzilla – Attachment 84382 Details for
Bug 20006
Adapt /v1/holds to new naming guidelines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20006: (follow-up) Fix holds.js
Bug-20006-follow-up-Fix-holdsjs.patch (text/plain), 1.51 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-01-24 18:22:30 UTC
(
hide
)
Description:
Bug 20006: (follow-up) Fix holds.js
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-01-24 18:22:30 UTC
Size:
1.51 KB
patch
obsolete
>From 95fb9bfb56cf1d13858815d97593f922d21dd8cd Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 24 Jan 2019 15:11:21 -0300 >Subject: [PATCH] Bug 20006: (follow-up) Fix holds.js > >This patch makes holds.js call the endpoint with 'pickup_library_id' >instead of the old 'branchcode' property. > >To test: >- Place a hold >- Go to the patron's detail page >- Go to the Holds tab >- Change the pickup location >=> SUCCESS: It works! >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index c6bc3e5d0f..75b9097a13 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -202,7 +202,7 @@ $(document).ready(function() { > var res_id = $(this).attr('reserve_id'); > $(this).after('<div id="updating_reserveno'+res_id+'" class="waiting"><img src="/intranet-tmpl/prog/img/spinner-small.gif" alt="" /><span class="waiting_msg"></span></div>'); > var api_url = '/api/v1/holds/'+res_id; >- var update_info = JSON.stringify({ branchcode: $(this).val(), priority: parseInt($(this).attr("priority"),10) }); >+ var update_info = JSON.stringify({ pickup_library_id: $(this).val(), priority: parseInt($(this).attr("priority"),10) }); > $.ajax({ > method: "PUT", > url: api_url, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20006
:
84374
|
84375
|
84376
|
84381
|
84382
|
84386
|
84395
|
84396
|
84397
|
84398
|
84399
|
85051
|
85052
|
85053
|
85054
|
85055
|
85856
|
85857
|
85858
|
85859
|
85860