Attachment 84444 Details for Bug 12283 – Bug 12283: Disable autocomplete for patron search inputs

[patch] Bug 12283: Disable autocomplete for patron search inputs

Bug-12283-Disable-autocomplete-for-patron-search-i.patch (text/plain), 4.50 KB, created by Katrin Fischer on 2019-01-26 12:35:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-01-26 12:35:45 UTC

Size: 4.50 KB

patch

obsolete

>From 685defc62ea0b8062e8187ab6c18ec95552e691b Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Wed, 17 Oct 2018 19:03:00 +0000
>Subject: [PATCH] Bug 12283: Disable autocomplete for patron search inputs
>
>In a production system, you don't usually search for the same
>patron over and over, so there's no sense for the browser
>to save a list of searched patrons in the patron quick
>search. Therefore, should set autocomplete=off for that
>input field.
>
>Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc       | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc     | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt     | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc
>index 3b6d0a0a84..91e6fe452d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc
>@@ -25,7 +25,7 @@
> <div id="patron_search" class="residentsearch">
>     <p class="tip">Enter patron card number or partial name:</p>
>     <form action="/cgi-bin/koha/members/member.pl" method="post">
>-        <input name="searchmember" class="head-searchbox" id="searchmember" size="40" type="text"/>
>+        <input name="searchmember" class="head-searchbox" id="searchmember" size="40" type="text" autocomplete="off" />
>         <input type="hidden" name="quicksearch" value="1" />
>         <input value="Submit" class="submit" type="submit" />
>     </form>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
>index a7050938ac..aec60d975e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
>@@ -12,7 +12,7 @@
>             [% END %]
>         </div>
> 	[% ELSE %]
>-            <input id="findborrower" name="findborrower" size="40" class="head-searchbox focus" type="text" />
>+            <input id="findborrower" name="findborrower" size="40" class="head-searchbox focus" type="text" autocomplete="off" />
>             [% IF ( stickyduedate ) %]
>             <input type="hidden" name="duedatespec" value="[% duedatespec | html %]" />
>             <input type="hidden" name="stickyduedate" value="[% stickyduedate | html %]" />
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>index 627eedb7fe..fbf8686ede 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>@@ -7,7 +7,7 @@
>     <div id="patron_search" class="residentsearch">
>     <p class="tip">Enter patron card number or partial name:</p>
>     <form action="/cgi-bin/koha/members/member.pl" method="post">
>-    <input id="searchmember" data-toggle="tooltip" size="25" class="head-searchbox focus" name="searchmember" type="text" value="[% searchmember | html %]"/>
>+    <input id="searchmember" data-toggle="tooltip" size="25" class="head-searchbox focus" name="searchmember" type="text" value="[% searchmember | html %]" autocomplete="off" />
>     <input type="hidden" name="quicksearch" value="1" />
>     <span class="filteraction" id="filteraction_off"> <a href="#">[-]</a></span>
>     <span class="filteraction" id="filteraction_on"> <a href="#">[+]</a></span>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 03823eefbe..676f24df09 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -70,7 +70,7 @@
>         [% UNLESS borrowers %]
>                 <label for="patron">Patron: </label>
>                 <div class="hint">Enter patron card number or partial name:</div>
>-                <input type="text" size="40" id="patron" class="focus" name="findborrower" />
>+                <input type="text" size="40" id="patron" class="focus" name="findborrower" autocomplete="off" />
>                 <input type="submit" value="Search" />
>             [% IF multi_hold %]
>                 <input type="hidden" name="multi_hold" value="[% multi_hold | html %]"/>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12283: 61374 | 80753 | 84441 | 84444