Bugzilla – Attachment 84520 Details for
Bug 20664
Optimize retrieval of biblio and item data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20664: (follow-up) Fix QA whitespace errors
Bug-20664-follow-up-Fix-QA-whitespace-errors.patch (text/plain), 1.73 KB, created by
Ere Maijala
on 2019-01-30 13:16:16 UTC
(
hide
)
Description:
Bug 20664: (follow-up) Fix QA whitespace errors
Filename:
MIME Type:
Creator:
Ere Maijala
Created:
2019-01-30 13:16:16 UTC
Size:
1.73 KB
patch
obsolete
>From e61400acb3462f764a2873aa7a70409ce2e8f91f Mon Sep 17 00:00:00 2001 >From: Ere Maijala <ere.maijala@helsinki.fi> >Date: Wed, 30 Jan 2019 15:00:27 +0200 >Subject: [PATCH] Bug 20664: (follow-up) Fix QA whitespace errors > >--- > C4/Items.pm | 6 +++--- > t/db_dependent/Items.t | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 36ba4c4bfc..5fcbc783e4 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1249,7 +1249,7 @@ sub GetHiddenItemnumbers { > # Don't hide anything from this borrower category > return; > } >- >+ > my @resultitems; > my $yaml = C4::Context->preference('OpacHiddenItems'); > return () if (! $yaml =~ /\S/ ); >@@ -1383,14 +1383,14 @@ sub Item2Marc { > > =head2 GetMarcItemFields > >- my @marc_fields = GetMarcItemFields($biblionumber); >+ my @marc_fields = GetMarcItemFields($biblionumber); > > Returns an array of MARC::Record objects of the items for the biblio. > > =cut > > sub GetMarcItemFields { >- my ( $biblionumber, $itemnumbers, $hidingrules ) = @_; >+ my ( $biblionumber, $itemnumbers, $hidingrules ) = @_; > > my $item_level_itype = C4::Context->preference('item-level_itypes'); > # This is so much faster than using Koha::Items->search that it makes sense even if it's ugly. >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index 8703225053..ad75cd309e 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -998,7 +998,7 @@ subtest 'tests for GetMarcItem' => sub { > subtest 'tests for GetMarcItemFields' => sub { > plan tests => 5; > $schema->storage->txn_begin; >- >+ > #Setup the information we need > my $builder = t::lib::TestBuilder->new; > my $library = $builder->build({ source => 'Branch', }); >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20664
:
74873
|
75968
|
76045
|
76046
|
76669
|
78868
|
78869
|
78870
|
79225
|
79227
|
79228
|
79229
|
79276
|
79277
|
79278
|
79279
|
84516
|
84517
|
84518
|
84519
|
84520
|
85106
|
85107
|
85108
|
85109
|
85110
|
85776
|
85777
|
85778
|
85779
|
85780
|
85781
|
85898
|
85899
|
85900
|
85901
|
85902
|
85903
|
85904
|
85905
|
86002
|
86003
|
86004
|
86005
|
86006
|
86007
|
86008
|
86009