Bugzilla – Attachment 84540 Details for
Bug 22239
JavaScript error on subscription detail page when there are no orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22239: JavaScript error on subscription detail page when there are no orders
Bug-22239-JavaScript-error-on-subscription-detail-.patch (text/plain), 1.71 KB, created by
Owen Leonard
on 2019-01-30 20:04:55 UTC
(
hide
)
Description:
Bug 22239: JavaScript error on subscription detail page when there are no orders
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-01-30 20:04:55 UTC
Size:
1.71 KB
patch
obsolete
>From 450ee2339a119cbbbde72869d82ff0b70416f56e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 30 Jan 2019 19:58:25 +0000 >Subject: [PATCH] Bug 22239: JavaScript error on subscription detail page when > there are no orders > >This page modifies the subscription detail page so that a JavaScript >error isn't triggered when a subscription has no acquisition details. > >To test, apply the patch and go to Serials. > > - Locate a subscription which isn't tied to acquisitions. In the > browser console there should be no errors. > - Locate a subscription which is part of an order. There should be an > 'Acquisitions details' tab and the order information on that tab > should be displayed as a collapsible tree. >--- > .../prog/en/modules/serials/subscription-detail.tt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 193b707..7a2567d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -505,10 +505,12 @@ > 'bSort': false, > }, columns_settings); > >- $(table).treetable({ >- expandable: true >- }); >- $(table).treetable('expandAll'); >+ [% IF orders_grouped.size %] >+ $(table).treetable({ >+ expandable: true >+ }); >+ $(table).treetable('expandAll'); >+ [% END %] > > $("#hide_received_orders").click(function(e){ > e.preventDefault(); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22239
:
84540
|
85190
|
85204