Bugzilla – Attachment 84641 Details for
Bug 22242
Javascript error in value builder cased by Select2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22242: Javascript error in value builder cased by Select2
Bug-22242-Javascript-error-in-value-builder-cased-.patch (text/plain), 3.07 KB, created by
Owen Leonard
on 2019-02-01 19:15:41 UTC
(
hide
)
Description:
Bug 22242: Javascript error in value builder cased by Select2
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-02-01 19:15:41 UTC
Size:
3.07 KB
patch
obsolete
>From 2f355a6db419df43126000c64a58edeff318863d Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 31 Jan 2019 09:12:13 +0100 >Subject: [PATCH] Bug 22242: Javascript error in value builder cased by Select2 > >Same as Bug 17780 but in value builders. > >Select2 (Bug 13501) introduced divs and inputs that broke some >assumptions about the expected HTML structure. This patch checks if >input has name attribute, because some inputs in Select2 have not. > >It brakes value builders marc21_linking_section.tt and >unimarc_field_4XX.tt. > >Test plan : >1) On a MARC21 database >2) Define 774$0 as a regular subfield >3) Define 774$4 with an authorised value category >4) Define 774$t with value builder marc21_linking_section >5) Create a new record >6) Use value builder in 774$t >7) Search for a record and click choose >8) Without patch : a popup window does not close and show a blank > screen >9) With patch : popup windows get close and you see in field 774 $0 and > $t field with values >10) Same tests with a UNIMARC database on field 461 with value builder > unimarc_field_4XX.tt > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Tested successfully with MARC21 >--- > .../prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt | 1 + > .../prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt >index 4b7f278..292d529 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt >@@ -144,6 +144,7 @@ > > var re = /^tag_\d*_code_/; > for (var i = 0, len = subfields.length; i < len; i++) { >+ if (subfields[i].hasAttribute('name') == 0) { continue; } // div elements specific to Select2 > if (subfields[i].getAttribute('name').match(re)) { // it s a subfield > var code = subfields[i]; > var subfield = subfields[i + 1]; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >index 8f613ad..2268a09 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >@@ -161,6 +161,7 @@ > > var re = /^tag_\d*_code_/; > for(var i=0, len = subfields.length ; i< len ; i++) { >+ if(subfields[i].hasAttribute('name') == 0) { continue; } // div elements specific to Select2 > if(subfields[i].getAttribute('name').match(re)){ // it s a subfield > var code = subfields[i]; > var subfield = subfields[i+1]; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22242
:
84565
|
84641
|
84656